github-starred/feeddeck
2
0
Fork 0
mirror of https://github.com/feeddeck/feeddeck.git synced 2026-03-09 07:02:01 -05:00
Code Issues 5 Packages Projects Releases 8 Wiki Activity

[PR #133] [MERGED] [core] Fix Password Validations #134

New Issue
Closed
opened 2025-10-31 16:58:01 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-10-31 16:58:01 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/feeddeck/feeddeck/pull/133
Author: @ricoberger
Created: 2/10/2024
Status: ✅ Merged
Merged: 2/10/2024
Merged by: @ricoberger

Base: main ← Head: fix-password-validations

📝 Commits (1)

  • 9614940 [core] Fix Password Validations

📊 Changes

4 files changed (+29 additions, -14 deletions)

View changed files

📝 app/lib/widgets/reset_password/reset_password.dart (+11 -3)
📝 app/lib/widgets/settings/profile/settings_profile_password.dart (+11 -3)
📝 app/lib/widgets/signin_with_feeddeck/signin_with_feeddeck.dart (+4 -7)
📝 app/lib/widgets/signup/signup.dart (+3 -1)

📄 Description

This commit fixes the password validations. In #130 we introduced some stronger password policies to forbid weak passwords, but forgot to change it in all places. Now the same rules are also applying when a user changes his password or resets his password.

During the sign in we do not use the same rules, to not block users which have already signed up, with a password which doesn't match the rules.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/feeddeck/feeddeck/pull/133 **Author:** [@ricoberger](https://github.com/ricoberger) **Created:** 2/10/2024 **Status:** ✅ Merged **Merged:** 2/10/2024 **Merged by:** [@ricoberger](https://github.com/ricoberger) **Base:** `main` ← **Head:** `fix-password-validations` --- ### 📝 Commits (1) - [`9614940`](https://github.com/feeddeck/feeddeck/commit/9614940494068105c2fda95d5504c5f421bdc9bf) [core] Fix Password Validations ### 📊 Changes **4 files changed** (+29 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `app/lib/widgets/reset_password/reset_password.dart` (+11 -3) 📝 `app/lib/widgets/settings/profile/settings_profile_password.dart` (+11 -3) 📝 `app/lib/widgets/signin_with_feeddeck/signin_with_feeddeck.dart` (+4 -7) 📝 `app/lib/widgets/signup/signup.dart` (+3 -1) </details> ### 📄 Description This commit fixes the password validations. In #130 we introduced some stronger password policies to forbid weak passwords, but forgot to change it in all places. Now the same rules are also applying when a user changes his password or resets his password. During the sign in we do not use the same rules, to not block users which have already signed up, with a password which doesn't match the rules. <!-- Keep PR title verbose enough and add prefix telling about what source it touches e.g "[rss] Add feature xyz" or if the the PR is not realated to a source use "[core]", e.g. "[core] Fix xyz". If you add a breaking change within your PR you should add ":warning:" to the title, e.g. ":warning: [core] My breaking change" --> <!-- Description of what have been changed. Please also reference an issue, when available. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-10-31 16:58:01 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/feeddeck#134
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?