github-starred/feeddeck
2
0
Fork 0
mirror of https://github.com/feeddeck/feeddeck.git synced 2026-03-09 07:02:01 -05:00
Code Issues 5 Packages Projects Releases 8 Wiki Activity

[PR #129] [MERGED] [rss] Do Not Remove HTML Tags #130

New Issue
Closed
opened 2025-10-31 16:57:56 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-10-31 16:57:56 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/feeddeck/feeddeck/pull/129
Author: @ricoberger
Created: 2/2/2024
Status: ✅ Merged
Merged: 2/2/2024
Merged by: @ricoberger

Base: main ← Head: rss-do-not-remove-html-tags

📝 Commits (1)

  • 5c864d8 [rss] Do Not Remove HTML Tags

📊 Changes

2 files changed (+5 additions, -5 deletions)

View changed files

📝 supabase/functions/_shared/feed/rss.ts (+2 -2)
📝 supabase/functions/_shared/feed/rss_test.ts (+3 -3)

📄 Description

We do not remove HTML tags from the description of a RSS feed item anymore, because:

  • This didn't worked for all feeds, because we first removed the tags and then unescape the data, which didn't make sense
  • We render the HTML to Makrdown in the frontend so that the description can contain HTML tags and is still properly rendered and in some case better rendered then before

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/feeddeck/feeddeck/pull/129 **Author:** [@ricoberger](https://github.com/ricoberger) **Created:** 2/2/2024 **Status:** ✅ Merged **Merged:** 2/2/2024 **Merged by:** [@ricoberger](https://github.com/ricoberger) **Base:** `main` ← **Head:** `rss-do-not-remove-html-tags` --- ### 📝 Commits (1) - [`5c864d8`](https://github.com/feeddeck/feeddeck/commit/5c864d862f5ad84d5c3be4d0cf026d3632fa37da) [rss] Do Not Remove HTML Tags ### 📊 Changes **2 files changed** (+5 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `supabase/functions/_shared/feed/rss.ts` (+2 -2) 📝 `supabase/functions/_shared/feed/rss_test.ts` (+3 -3) </details> ### 📄 Description We do not remove HTML tags from the description of a RSS feed item anymore, because: - This didn't worked for all feeds, because we first removed the tags and then unescape the data, which didn't make sense - We render the HTML to Makrdown in the frontend so that the description can contain HTML tags and is still properly rendered and in some case better rendered then before <!-- Keep PR title verbose enough and add prefix telling about what source it touches e.g "[rss] Add feature xyz" or if the the PR is not realated to a source use "[core]", e.g. "[core] Fix xyz". If you add a breaking change within your PR you should add ":warning:" to the title, e.g. ":warning: [core] My breaking change" --> <!-- Description of what have been changed. Please also reference an issue, when available. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-10-31 16:57:56 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/feeddeck#130
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?