github-starred/feeddeck
2
0
Fork 0
mirror of https://github.com/feeddeck/feeddeck.git synced 2026-04-28 01:48:28 -05:00
Code Issues 89 Packages Projects Releases 8 Wiki Activity

[core] Fix ItemsRepository Status (#45)

Browse Source 
This commit fixes the status of an ItemsRepository when the repository
is initalized from the ItemsRepositoryStore instead of the "_getItems"
function.

After the repository was initialized from the ItemsRepositoryStore we
always set the status of the repository to "loaded", also when we had
less then 50 items. Because of that we also always displayed the "Load
More" button. This is now fixed by adding the status of the repository
to the ItemsRepositoryStore, so that the "Load More" button is only
shown when there are more items to load.
This commit is contained in:
Rico Berger
2023-10-22 12:21:00 +02:00
committed by GitHub
parent f60b8795dc
commit 74664612fd
1 changed files with 23 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
app/lib/repositories/items_repository.dart
View File

@@ -105,9 +105,9 @@ class ItemsRepository with ChangeNotifier {
Future<void> _init() async {
final state = ItemsRepositoryStore().get(column.identifier());
if (state != null) {
_status = ItemsStatus.loaded;
_items.addAll(state.items);
_status = state.status;
_filters = state.filters;
_items.addAll(state.items);
notifyListeners();
} else {
await _getItems();
@@ -189,7 +189,12 @@ class ItemsRepository with ChangeNotifier {
/// Finally we store the state of the repository, so that we do not have
/// to retrieve the items from the database again when therepository is
/// reinitialized.
ItemsRepositoryStore().set(column.identifier(), _items, _filters);
ItemsRepositoryStore().set(
column.identifier(),
_status,
_filters,
_items,
);
notifyListeners();
} catch (_) {
_status = ItemsStatus.loaded;
@@ -278,7 +283,7 @@ class ItemsRepository with ChangeNotifier {
}
}
ItemsRepositoryStore().set(column.id, _items, _filters);
ItemsRepositoryStore().set(column.id, _status, _filters, _items);
notifyListeners();
} catch (err) {
rethrow;
@@ -308,7 +313,7 @@ class ItemsRepository with ChangeNotifier {
}
}
ItemsRepositoryStore().set(column.id, _items, _filters);
ItemsRepositoryStore().set(column.id, _status, _filters, _items);
notifyListeners();
} catch (err) {
rethrow;
@@ -330,7 +335,7 @@ class ItemsRepository with ChangeNotifier {
}
}
ItemsRepositoryStore().set(column.id, _items, _filters);
ItemsRepositoryStore().set(column.id, _status, _filters, _items);
notifyListeners();
} catch (err) {
rethrow;
@@ -342,12 +347,14 @@ class ItemsRepository with ChangeNotifier {
/// in the [ItemsRepositoryStore]. The state contains all the loaded [items] and
/// the [filters] set by user to load the items.
class ItemsRepositoryStoreState {
List<FDItem> items;
ItemsStatus status;
ItemsFilters filters;
List<FDItem> items;
ItemsRepositoryStoreState({
required this.items,
required this.status,
required this.filters,
required this.items,
});
}
@@ -384,10 +391,16 @@ class ItemsRepositoryStore {
///
/// The best is to call the [set] function right before we call
/// `notifyListeners` in the repository.
set(String columnId, List<FDItem> items, ItemsFilters filters) {
set(
String columnId,
ItemsStatus status,
ItemsFilters filters,
List<FDItem> items,
) {
return itemsRepositoryStoreStates[columnId] = ItemsRepositoryStoreState(
items: items,
status: status,
filters: filters,
items: items,
);
}
}