github-starred/feeddeck
2
0
Fork 0
mirror of https://github.com/feeddeck/feeddeck.git synced 2026-03-09 07:02:01 -05:00
Code Issues 5 Packages Projects Releases 8 Wiki Activity

Improve openUrl Function (#262)

Browse Source 
Instead of using an external browser on Android, we are now using the
In-App-Browser to open all urls. For all other platforms we keep the
current behaviour and just set the launch mode explicitly, for the case
the the default is changed in the used package.
This commit is contained in:
Rico Berger
2025-05-11 11:11:00 +02:00
committed by GitHub
parent 3a8308b66c
commit 2d838240fd
1 changed files with 19 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
app/lib/utils/openurl.dart
View File

@@ -4,24 +4,29 @@ import 'package:flutter/foundation.dart' show kIsWeb;
import 'package:url_launcher/url_launcher.dart';
/// [openUrl] can be used to open the given [url] in the platforms default
/// browser.
/// [openUrl] can be used to open the given [url] in the specified launch mode.
/// For iOS and Android we are using the In-App-Browser to launch the url, for
/// all other platforms we are using the external browser.
///
/// On Android we are not using the default launch mode
/// (`LaunchMode.platformDefault`), because the opened In-App-Browser is very
/// limited, so that we decided to use `LaunchMode.externalApplication` to open
/// the url.
/// We do not have to check if the launch mode is really supported, because
/// `launchUrl` will fallback to a supported launch mode, when our preferred
/// mode is not supported.
Future<void> openUrl(String url) async {
var launchMode = LaunchMode.platformDefault;
if (!kIsWeb) {
if (Platform.isAndroid) {
launchMode = LaunchMode.externalApplication;
}
if (kIsWeb) {
launchMode = LaunchMode.externalApplication;
} else if (Platform.isAndroid) {
launchMode = LaunchMode.inAppBrowserView;
} else if (Platform.isIOS) {
launchMode = LaunchMode.inAppBrowserView;
} else if (Platform.isMacOS) {
launchMode = LaunchMode.externalApplication;
} else if (Platform.isLinux) {
launchMode = LaunchMode.externalApplication;
} else if (Platform.isWindows) {
launchMode = LaunchMode.externalApplication;
}
await launchUrl(
Uri.parse(url),
mode: launchMode,
);
await launchUrl(Uri.parse(url), mode: launchMode);
}