github-starred/cs249r_book
2
0
Fork 0
mirror of https://github.com/harvard-edge/cs249r_book.git synced 2026-05-21 13:31:55 -05:00
Code Issues 114 Packages Projects Releases 24 Wiki Activity

[PR #1159] [MERGED] Merge dev → main: CI fixes, attention/GELU corrections, contributor updates #2372

New Issue
Closed
opened 2026-04-11 08:25:52 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-11 08:25:52 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/harvard-edge/cs249r_book/pull/1159
Author: @profvjreddi
Created: 2/4/2026
Status: ✅ Merged
Merged: 2/4/2026
Merged by: @profvjreddi

Base: main ← Head: dev

📝 Commits (10+)

  • 5f6a846 fix(tito-milestone): align bold cyan frame and correct "Press Enter" color
  • 668a50a feat: add step-by-step visualization to milestones
  • 83a3ce3 fix(ci): use pull_request_target for auto-label write permissions
  • d596c3b Merge pull request #1153 from harvard-edge/fix/auto-label-permissions
  • 3e3a635 Merge pull request #1152 from AndreaMattiaGaravagno/fix/milestone-frame-alignment
  • a33d600 docs: add @AndreaMattiaGaravagno as tinytorch contributor for code
  • 819ed75 Merge pull request #1151 from AndreaMattiaGaravagno/feature/step-by-step-milestone-visualization
  • 1a80e57 docs: add @AndreaMattiaGaravagno as book contributor for code
  • 20a4ba2 fix(attention): correct O(n²) complexity explanation and memory table bug
  • 85ed754 Merge feature/tinytorch-core: fix attention complexity and memory table (fixes #1150)

📊 Changes

18 files changed (+237 additions, -83 deletions)

View changed files

📝 .github/workflows/auto-label.yml (+1 -1)
📝 README.md (+2 -0)
📝 book/.all-contributorsrc (+9 -0)
📝 book/README.md (+1 -0)
📝 tinytorch/.all-contributorsrc (+9 -0)
📝 tinytorch/README.md (+1 -0)
📝 tinytorch/milestones/01_1958_perceptron/01_rosenblatt_forward.py (+19 -10)
📝 tinytorch/milestones/02_1969_xor/01_xor_crisis.py (+19 -5)
📝 tinytorch/milestones/02_1969_xor/02_xor_solved.py (+18 -7)
📝 tinytorch/milestones/03_1986_mlp/01_rumelhart_tinydigits.py (+29 -9)
📝 tinytorch/milestones/04_1998_cnn/01_lecun_tinydigits.py (+18 -7)
📝 tinytorch/milestones/05_2017_transformer/01_vaswani_attention.py (+24 -9)
📝 tinytorch/milestones/06_2018_mlperf/01_optimization_olympics.py (+25 -11)
📝 tinytorch/milestones/06_2018_mlperf/02_generation_speedup.py (+23 -8)
📝 tinytorch/scripts/test-fresh-install.sh (+1 -1)
📝 tinytorch/src/02_activations/02_activations.py (+14 -3)
📝 tinytorch/src/12_attention/12_attention.py (+10 -7)
📝 tinytorch/tito/commands/milestone.py (+14 -5)

📄 Description

Summary

Brings main up to date with dev. Key changes:

CI/Workflow fixes:

  • fix(ci): use pull_request_target for auto-label write permissions (#1153)
  • fix(ci): use pipe delimiter in sed for branch names with / in fresh install test (#1158)

TinyTorch module fixes (Issues #1150, #1154):

  • fix(attention): correct O(n²×d) complexity explanation and memory table bug
  • fix(activations): correct GELU 1.702 hint + expanded explanation with both approximation forms

Community:

  • Contributor updates for @AndreaMattiaGaravagno
  • Step-by-step milestone visualization (#1151, #1152)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/harvard-edge/cs249r_book/pull/1159 **Author:** [@profvjreddi](https://github.com/profvjreddi) **Created:** 2/4/2026 **Status:** ✅ Merged **Merged:** 2/4/2026 **Merged by:** [@profvjreddi](https://github.com/profvjreddi) **Base:** `main` ← **Head:** `dev` --- ### 📝 Commits (10+) - [`5f6a846`](https://github.com/harvard-edge/cs249r_book/commit/5f6a8468f3c9392102463da1c8aeab2bb990105b) fix(tito-milestone): align bold cyan frame and correct "Press Enter" color - [`668a50a`](https://github.com/harvard-edge/cs249r_book/commit/668a50af873c9ff987713b362736f150e36bfd5b) feat: add step-by-step visualization to milestones - [`83a3ce3`](https://github.com/harvard-edge/cs249r_book/commit/83a3ce3712c9985605ecf1cbe48b0514dc843a6c) fix(ci): use pull_request_target for auto-label write permissions - [`d596c3b`](https://github.com/harvard-edge/cs249r_book/commit/d596c3bb0f603eb1e2f6c966abc268fe5ffb7b57) Merge pull request #1153 from harvard-edge/fix/auto-label-permissions - [`3e3a635`](https://github.com/harvard-edge/cs249r_book/commit/3e3a635a7069068eb983055fc3f19d0bc0663305) Merge pull request #1152 from AndreaMattiaGaravagno/fix/milestone-frame-alignment - [`a33d600`](https://github.com/harvard-edge/cs249r_book/commit/a33d600fbdd5156f1578d6b75c1782cf04719056) docs: add @AndreaMattiaGaravagno as tinytorch contributor for code - [`819ed75`](https://github.com/harvard-edge/cs249r_book/commit/819ed75bc1524cefda85af57ceb3b84a566d149a) Merge pull request #1151 from AndreaMattiaGaravagno/feature/step-by-step-milestone-visualization - [`1a80e57`](https://github.com/harvard-edge/cs249r_book/commit/1a80e57fa07a5e551641df8db4dd2131524cb31f) docs: add @AndreaMattiaGaravagno as book contributor for code - [`20a4ba2`](https://github.com/harvard-edge/cs249r_book/commit/20a4ba237998dfacba0cfae03b8a71247c1d0fd6) fix(attention): correct O(n²) complexity explanation and memory table bug - [`85ed754`](https://github.com/harvard-edge/cs249r_book/commit/85ed754354b08790013a6fad725dcad0eec17f8e) Merge feature/tinytorch-core: fix attention complexity and memory table (fixes #1150) ### 📊 Changes **18 files changed** (+237 additions, -83 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/auto-label.yml` (+1 -1) 📝 `README.md` (+2 -0) 📝 `book/.all-contributorsrc` (+9 -0) 📝 `book/README.md` (+1 -0) 📝 `tinytorch/.all-contributorsrc` (+9 -0) 📝 `tinytorch/README.md` (+1 -0) 📝 `tinytorch/milestones/01_1958_perceptron/01_rosenblatt_forward.py` (+19 -10) 📝 `tinytorch/milestones/02_1969_xor/01_xor_crisis.py` (+19 -5) 📝 `tinytorch/milestones/02_1969_xor/02_xor_solved.py` (+18 -7) 📝 `tinytorch/milestones/03_1986_mlp/01_rumelhart_tinydigits.py` (+29 -9) 📝 `tinytorch/milestones/04_1998_cnn/01_lecun_tinydigits.py` (+18 -7) 📝 `tinytorch/milestones/05_2017_transformer/01_vaswani_attention.py` (+24 -9) 📝 `tinytorch/milestones/06_2018_mlperf/01_optimization_olympics.py` (+25 -11) 📝 `tinytorch/milestones/06_2018_mlperf/02_generation_speedup.py` (+23 -8) 📝 `tinytorch/scripts/test-fresh-install.sh` (+1 -1) 📝 `tinytorch/src/02_activations/02_activations.py` (+14 -3) 📝 `tinytorch/src/12_attention/12_attention.py` (+10 -7) 📝 `tinytorch/tito/commands/milestone.py` (+14 -5) </details> ### 📄 Description ## Summary Brings main up to date with dev. Key changes: **CI/Workflow fixes:** - fix(ci): use `pull_request_target` for auto-label write permissions (#1153) - fix(ci): use pipe delimiter in `sed` for branch names with `/` in fresh install test (#1158) **TinyTorch module fixes (Issues #1150, #1154):** - fix(attention): correct O(n²×d) complexity explanation and memory table bug - fix(activations): correct GELU 1.702 hint + expanded explanation with both approximation forms **Community:** - Contributor updates for @AndreaMattiaGaravagno - Step-by-step milestone visualization (#1151, #1152) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-11 08:25:52 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area: book
area: collabs
area: kits
area: labs
area: socratiq
area: tinytorch
area: tools
area: website
bug
dependencies
format: epub
format: pdf
javascript
link-health
link-rot
priority-high
pull-request
Mirrored from GitHub Pull Request
 staffml
type: bug
type: citation
type: code
type: errata
type: improvement
type: new
type: question
vault-sli
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/cs249r_book#2372
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?