github-starred/cs249r_book
2
0
Fork 0
mirror of https://github.com/harvard-edge/cs249r_book.git synced 2026-07-16 14:42:29 -05:00
Code Issues 276 Packages Projects Releases 26 Wiki Activity

[PR #1182] [MERGED] Improve dataset extraction robustness #1158

New Issue
Closed
opened 2026-03-22 16:02:22 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-22 16:02:22 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/harvard-edge/cs249r_book/pull/1182
Author: @RinZ27
Created: 2/19/2026
Status: ✅ Merged
Merged: 2/22/2026
Merged by: @profvjreddi

Base: dev ← Head: fix/safe-data-extraction

📝 Commits (1)

  • 7d2cd5a Improve robustness of dataset extraction by validating paths

📊 Changes

1 file changed (+14 additions, -1 deletions)

View changed files

📝 tinytorch/milestones/data_manager.py (+14 -1)

📄 Description

Updated the dataset extraction logic in data_manager.py to include path validation. This ensures that when extracting the CIFAR-10 dataset, all members are strictly contained within the target directory, preventing potential file system issues or unintended overwrites. I noticed the current implementation uses extractall() directly, so adding this check makes the process much more robust for students working with the framework.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/harvard-edge/cs249r_book/pull/1182 **Author:** [@RinZ27](https://github.com/RinZ27) **Created:** 2/19/2026 **Status:** ✅ Merged **Merged:** 2/22/2026 **Merged by:** [@profvjreddi](https://github.com/profvjreddi) **Base:** `dev` ← **Head:** `fix/safe-data-extraction` --- ### 📝 Commits (1) - [`7d2cd5a`](https://github.com/harvard-edge/cs249r_book/commit/7d2cd5a47dca76d30345c72bb356f9fd1ca140e0) Improve robustness of dataset extraction by validating paths ### 📊 Changes **1 file changed** (+14 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `tinytorch/milestones/data_manager.py` (+14 -1) </details> ### 📄 Description Updated the dataset extraction logic in `data_manager.py` to include path validation. This ensures that when extracting the CIFAR-10 dataset, all members are strictly contained within the target directory, preventing potential file system issues or unintended overwrites. I noticed the current implementation uses `extractall()` directly, so adding this check makes the process much more robust for students working with the framework. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-22 16:02:22 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area: book
area: collabs
area: kits
area: labs
area: socratiq
area: staffml
area: tinytorch
area: tools
area: website
bug
dependencies
format: epub
format: pdf
javascript
link-health
link-rot
priority-high
pull-request
Mirrored from GitHub Pull Request
 staffml
type: bug
type: citation
type: code
type: errata
type: improvement
type: new
type: question
vault-sli
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/cs249r_book#1158
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?