github-starred/cs249r_book
2
0
Fork 0
mirror of https://github.com/harvard-edge/cs249r_book.git synced 2026-05-23 07:23:03 -05:00
Code Issues 114 Packages Projects Releases 24 Wiki Activity

[GH-ISSUE #1109] Unit Tested Failed for Module 03 in Tinytorch #1696

New Issue
Closed
opened 2026-04-11 08:02:52 -05:00 by GiteaMirror · 2 comments
GiteaMirror commented 2026-04-11 08:02:52 -05:00
Owner
Copy Link

Originally created by @Takosaga on GitHub (Jan 13, 2026).
Original GitHub issue: https://github.com/harvard-edge/cs249r_book/issues/1109

Originally assigned to: @profvjreddi on GitHub.

Using notebook created from tito module start 03, the tests fail in the notebook due to requires_grad=True flag for the weight and bias even though it states the flag marks these tensors for gradient computation in Module 06. Though I remove in the notebook to pass the test, tito module complete 03 has ❌ Unit tests failed at test_unit_linear_layer()

I used tito module reset 03 to reset notebook and still get same errors.

Originally created by @Takosaga on GitHub (Jan 13, 2026). Original GitHub issue: https://github.com/harvard-edge/cs249r_book/issues/1109 Originally assigned to: @profvjreddi on GitHub. Using notebook created from `tito module start 03`, the tests fail in the notebook due to `requires_grad=True` flag for the weight and bias even though it states the flag marks these tensors for gradient computation in Module 06. Though I remove in the notebook to pass the test, `tito module complete 03` has ❌ Unit tests failed at `test_unit_linear_layer()` I used `tito module reset 03` to reset notebook and still get same errors.
GiteaMirror commented 2026-04-11 08:02:53 -05:00
Author
Owner
Copy Link

@profvjreddi commented on GitHub (Jan 13, 2026):

Hi!

This is the same issue I just fixed this morning.

Module 03 was incorrectly using requires_grad=True before it's introduced in Module 06.

Please pull the latest dev branch and run tito module reset 03 again.

The fix is in commit https://github.com/harvard-edge/cs249r_book/commit/a36340690

Thanks for reporting!

I will start creating tags so it is easier to know which fixes were done etc.

<!-- gh-comment-id:3745604538 --> @profvjreddi commented on GitHub (Jan 13, 2026): Hi! This is the same issue I just fixed this morning. Module 03 was incorrectly using requires_grad=True before it's introduced in Module 06. Please pull the latest dev branch and run tito module reset 03 again. The fix is in commit https://github.com/harvard-edge/cs249r_book/commit/a36340690 Thanks for reporting! I will start creating tags so it is easier to know which fixes were done etc.
GiteaMirror commented 2026-04-11 08:02:53 -05:00
Author
Owner
Copy Link

@profvjreddi commented on GitHub (Jan 23, 2026):

v0.1.4 is now released with this fix! See #1129 for update instructions.

<!-- gh-comment-id:3787479268 --> @profvjreddi commented on GitHub (Jan 23, 2026): v0.1.4 is now released with this fix! See #1129 for update instructions.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area: book
area: collabs
area: kits
area: labs
area: socratiq
area: tinytorch
area: tools
area: website
bug
dependencies
format: epub
format: pdf
javascript
link-health
link-rot
priority-high
pull-request
Mirrored from GitHub Pull Request
 staffml
type: bug
type: citation
type: code
type: errata
type: improvement
type: new
type: question
vault-sli
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/cs249r_book#1696
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?