[PR #1119] [CLOSED] Fix tensor's matmul method to reject 0D tensors #1129

New Issue

GiteaMirror · 2026-03-22T16:01:26-05:00

GiteaMirror commented

2026-03-22 16:01:26 -05:00

📋 Pull Request Information

Original PR: https://github.com/harvard-edge/cs249r_book/pull/1119
Author: @minhdang26403
Created: 1/20/2026
Status: ❌ Closed

Base: dev ← Head: fix/tensor-matmul

📝 Commits (2)

cfd5449 fix: fix memory calculation result
8f387b9 fix: matmul should not allow 0D tensors

📊 Changes

2 files changed (+10 additions, -12 deletions)

View changed files

📝 tinytorch/src/01_tensor/01_tensor.py (+9 -11)
📝 tinytorch/src/01_tensor/ABOUT.md (+1 -1)

📄 Description

Both NumPy and PyTorch do not allow operands of the matmul operation to be 0D tensors. To make TinyTorch achieve the same functionality as PyTorch, the method matmul should raise error when it receives a 0D tensor. For 0D tensor multiplication, users should use element-wise multiplication *.

All Tensor module tests pass and there is no regression.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/harvard-edge/cs249r_book/pull/1119 **Author:** [@minhdang26403](https://github.com/minhdang26403) **Created:** 1/20/2026 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `fix/tensor-matmul` --- ### 📝 Commits (2) - [`cfd5449`](https://github.com/harvard-edge/cs249r_book/commit/cfd5449df9a7fa2695a8dbb5489efabac18ac5df) fix: fix memory calculation result - [`8f387b9`](https://github.com/harvard-edge/cs249r_book/commit/8f387b915e870c15c0842c359ee612663db84812) fix: matmul should not allow 0D tensors ### 📊 Changes **2 files changed** (+10 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `tinytorch/src/01_tensor/01_tensor.py` (+9 -11) 📝 `tinytorch/src/01_tensor/ABOUT.md` (+1 -1) </details> ### 📄 Description Both NumPy and PyTorch do not allow operands of the matmul operation to be 0D tensors. To make TinyTorch achieve the same functionality as PyTorch, the method matmul should raise error when it receives a 0D tensor. For 0D tensor multiplication, users should use element-wise multiplication `*`. All Tensor module tests pass and there is no regression. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-03-22 16:01:26 -05:00

GiteaMirror closed this issue

2026-03-22 16:01:28 -05:00

GiteaMirror referenced this issue

2026-04-11 08:02:53 -05:00

[GH-ISSUE #1109] Unit Tested Failed for Module 03 in Tinytorch #1696

GiteaMirror referenced this issue

2026-04-11 08:03:22 -05:00

[GH-ISSUE #1129] Error: tito milestone run 03 #1702

GiteaMirror referenced this issue

2026-04-19 12:18:23 -05:00

[GH-ISSUE #1109] Unit Tested Failed for Module 03 in Tinytorch #4316