github-starred/cs249r_book
2
0
Fork 0
mirror of https://github.com/harvard-edge/cs249r_book.git synced 2026-07-17 16:34:48 -05:00
Code Issues 276 Packages Projects Releases 26 Wiki Activity

[PR #1641] [MERGED] fix(slides): readable inventory tables on landing page #11824

New Issue
Closed
opened 2026-05-12 19:30:06 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-12 19:30:06 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/harvard-edge/cs249r_book/pull/1641
Author: @farhan523
Created: 5/4/2026
Status: ✅ Merged
Merged: 5/4/2026
Merged by: @profvjreddi

Base: dev ← Head: fix/slides-landing-readability

📝 Commits (1)

  • ecbc4ef fix(slides): readable inventory tables on landing page in dark mode

📊 Changes

1 file changed (+13 additions, -0 deletions)

View changed files

📝 slides/assets/styles/dark-mode.scss (+13 -0)

📄 Description

Summary

  • The .inv-table blocks on the slides landing page (What's Included, Related Resources) hardcoded light-mode text/border colors, so the rows became unreadable against the dark theme.
  • Added scoped overrides in slides/assets/styles/dark-mode.scss for the column text, row hover, and last-column action links (using the slides accent).

Before:
Screenshot 2026-05-04 085909

After:
Screenshot 2026-05-04 085914

Test plan

  • Open /slides/ in dark mode — What's Included and Related Resources rows are readable.
  • Hover row tints subtly without flashing to light.
  • Last-column action links use the rose accent ($slides-accent-dark).
  • Light mode is unchanged.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/harvard-edge/cs249r_book/pull/1641 **Author:** [@farhan523](https://github.com/farhan523) **Created:** 5/4/2026 **Status:** ✅ Merged **Merged:** 5/4/2026 **Merged by:** [@profvjreddi](https://github.com/profvjreddi) **Base:** `dev` ← **Head:** `fix/slides-landing-readability` --- ### 📝 Commits (1) - [`ecbc4ef`](https://github.com/harvard-edge/cs249r_book/commit/ecbc4efcce3c44af52760f9b976c28b4bb010de6) fix(slides): readable inventory tables on landing page in dark mode ### 📊 Changes **1 file changed** (+13 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `slides/assets/styles/dark-mode.scss` (+13 -0) </details> ### 📄 Description ## Summary - The `.inv-table` blocks on the slides landing page (What's Included, Related Resources) hardcoded light-mode text/border colors, so the rows became unreadable against the dark theme. - Added scoped overrides in `slides/assets/styles/dark-mode.scss` for the column text, row hover, and last-column action links (using the slides accent). Before: <img width="673" height="685" alt="Screenshot 2026-05-04 085909" src="https://github.com/user-attachments/assets/93012c88-5678-470b-b575-5ed8ade5e873" /> After: <img width="677" height="716" alt="Screenshot 2026-05-04 085914" src="https://github.com/user-attachments/assets/1be757b1-54a5-4816-9321-8b0d72b2453e" /> ## Test plan - [ ] Open `/slides/` in dark mode — What's Included and Related Resources rows are readable. - [ ] Hover row tints subtly without flashing to light. - [ ] Last-column action links use the rose accent (`$slides-accent-dark`). - [ ] Light mode is unchanged. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-12 19:30:06 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area: book
area: collabs
area: kits
area: labs
area: socratiq
area: staffml
area: tinytorch
area: tools
area: website
bug
dependencies
format: epub
format: pdf
javascript
link-health
link-rot
priority-high
pull-request
Mirrored from GitHub Pull Request
 staffml
type: bug
type: citation
type: code
type: errata
type: improvement
type: new
type: question
vault-sli
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/cs249r_book#11824
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?