github-starred/cs249r_book
2
0
Fork 0
mirror of https://github.com/harvard-edge/cs249r_book.git synced 2026-05-06 17:49:07 -05:00
Code Issues 85 Packages Projects Releases 24 Wiki Activity

[PR #1158] [MERGED] fix(ci): handle branch names with slashes in fresh install test #1148

New Issue
Closed
opened 2026-03-22 16:02:04 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-22 16:02:04 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/harvard-edge/cs249r_book/pull/1158
Author: @profvjreddi
Created: 2/4/2026
Status: ✅ Merged
Merged: 2/4/2026
Merged by: @profvjreddi

Base: dev ← Head: feature/tinytorch-core

📝 Commits (1)

  • 19093ce fix(ci): use pipe delimiter in sed to handle branch names with slashes

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 tinytorch/scripts/test-fresh-install.sh (+1 -1)

📄 Description

Summary

  • Fixes sed delimiter in test-fresh-install.sh from / to | so branch names containing / (e.g. feature/foo, 1156/merge) don't break the substitution

Test plan

  • Verified sed "s|__BRANCH__|feature/tinytorch-core|g" works correctly

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/harvard-edge/cs249r_book/pull/1158 **Author:** [@profvjreddi](https://github.com/profvjreddi) **Created:** 2/4/2026 **Status:** ✅ Merged **Merged:** 2/4/2026 **Merged by:** [@profvjreddi](https://github.com/profvjreddi) **Base:** `dev` ← **Head:** `feature/tinytorch-core` --- ### 📝 Commits (1) - [`19093ce`](https://github.com/harvard-edge/cs249r_book/commit/19093cec1bc09bc7d911477ff818200d0d71e783) fix(ci): use pipe delimiter in sed to handle branch names with slashes ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `tinytorch/scripts/test-fresh-install.sh` (+1 -1) </details> ### 📄 Description ## Summary - Fixes `sed` delimiter in `test-fresh-install.sh` from `/` to `|` so branch names containing `/` (e.g. `feature/foo`, `1156/merge`) don't break the substitution ## Test plan - [x] Verified `sed "s|__BRANCH__|feature/tinytorch-core|g"` works correctly --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-22 16:02:04 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area: book
area: collabs
area: kits
area: socratiq
area: tinytorch
area: tools
area: website
bug
dependencies
format: epub
format: pdf
link-health
link-rot
priority-high
pull-request
Mirrored from GitHub Pull Request
 staffml
type: bug
type: citation
type: code
type: errata
type: improvement
type: new
type: question
vault-sli
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/cs249r_book#1148
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?