github-starred/cs249r_book
2
0
Fork 0
mirror of https://github.com/harvard-edge/cs249r_book.git synced 2026-03-11 17:49:25 -05:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1169 from adil-mubashir-ch/fix/windows-install-issues

Browse Source 
Merging Windows install fixes from first-time contributor @adil-mubashir-ch. Follow-up cleanup patch incoming.
This commit is contained in:
Vijay Janapa Reddi
2026-02-13 11:38:25 -05:00
committed by GitHub
parent 8dd73eebd6 f2975daa67
commit 8d8ff38399
2 changed files with 40 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
tinytorch/site/extra/install.sh
View File

@@ -205,9 +205,17 @@ check_python_version() {
# Find the best Python command (prioritize newer versions)
get_python_cmd() {
local platform
platform=$(get_platform)
# Check specific versions first, prioritizing newer versions
local candidates=("python3.13" "python3.12" "python3.11" "python3.10" "python3.9" "python3.8" "python3" "python")
# FIX: windows to fix microsoft store alis stuf
if [ "$platform" = "windows" ]; then
local candidates=("python")
else
local candidates=("python3.13" "python3.12" "python3.11" "python3.10" "python3.9" "python3.8" "python3" "python")
fi
for cmd in "${candidates[@]}"; do
if command_exists "$cmd"; then
# Verify this specific candidate actually meets the version requirement

50
tinytorch/tito/commands/setup.py
View File

@@ -128,6 +128,10 @@ class SetupCommand(BaseCommand):
def install_packages(self) -> bool:
"""Install required packages for Tiny🔥Torch development."""
# FIX: Windows Specific flags
is_windows = platform.system() == "Windows"
# Essential packages for TinyTorch
packages = [
("numpy", "numpy>=1.21.0"),
@@ -196,30 +200,36 @@ class SetupCommand(BaseCommand):
return False
# Install Tiny🔥Torch in development mode
with Progress(
SpinnerColumn(),
TextColumn("[progress.description]{task.description}"),
console=self.console
) as progress:
task = progress.add_task("Installing Tiny🔥Torch in development mode...", total=None)
# FIX: Skip installation on windows
if is_windows and self._check_package_installed("tinytorch"):
self.console.print(
"[green]✅ Tiny🔥Torch already installed (skipping reinstall on Windows)[/green]"
)
else:
with Progress(
SpinnerColumn(),
TextColumn("[progress.description]{task.description}"),
console=self.console
) as progress:
task = progress.add_task("Installing Tiny🔥Torch in development mode...", total=None)
try:
result = subprocess.run([
sys.executable, "-m", "pip", "install", "-q", "-e", "."
], cwd=self.config.project_root, capture_output=True, text=True, timeout=120)
try:
result = subprocess.run([
sys.executable, "-m", "pip", "install", "-q", "-e", "."
], cwd=self.config.project_root, capture_output=True, text=True, timeout=120)
if result.returncode == 0:
progress.update(task, description="[green]✅ Tiny🔥Torch installed[/green]")
else:
progress.update(task, description="[red]❌ Tiny🔥Torch install failed[/red]")
self.console.print(f"[red]Failed to install Tiny🔥Torch: {result.stderr}[/red]")
if result.returncode == 0:
progress.update(task, description="[green]✅ Tiny🔥Torch installed[/green]")
else:
progress.update(task, description="[red]❌ Tiny🔥Torch install failed[/red]")
self.console.print(f"[red]Failed to install Tiny🔥Torch: {result.stderr}[/red]")
return False
except Exception as e:
progress.update(task, description="[red]❌ Tiny🔥Torch error[/red]")
self.console.print(f"[red]Error installing Tiny🔥Torch: {e}[/red]")
return False
except Exception as e:
progress.update(task, description="[red]❌ Tiny🔥Torch error[/red]")
self.console.print(f"[red]Error installing Tiny🔥Torch: {e}[/red]")
return False
# Register Jupyter kernel so notebooks use this Python environment
self.console.print()
self.console.print("[bold]Registering Jupyter kernel...[/bold]")