github-starred/conventionalcommits.org
2
0
Fork 0
mirror of https://github.com/conventional-commits/conventionalcommits.org.git synced 2026-03-22 12:44:37 -05:00
Code Issues 153 Packages Projects Releases Wiki Activity

I think there are some bad examples in the portuguese version #151

New Issue
Closed
opened 2026-02-17 11:49:56 -06:00 by GiteaMirror · 7 comments
GiteaMirror commented 2026-02-17 11:49:56 -06:00
Owner
Copy Link

Originally created by @yudi-azvd on GitHub (Jul 1, 2022).

In the portuguese version of conventional commits, I think there are some bad examples like the following (link):

## Mensagem de commit com ! para chamar a atenção para quebra a compatibilidade

refactor!: remove suporte para Node 6

Which translates to

## Commit message with ! to draw attention to breaking change

refactor!: removes support for Node 6

Maybe this example is not adequate since refactoring means changing the internal structure without modifying observable behavior (Refactoring, Kent Beck). Refactor and breaking changes shouldn't be in the same commit/PR, right?

I'm no expert in software development or refactoring, I'm still learning things. So I'm if I understood something, please tell me :D

Originally created by @yudi-azvd on GitHub (Jul 1, 2022). In the [portuguese version of conventional commits](https://www.conventionalcommits.org/pt-br/v1.0.0/), I think there are some bad examples like the following ([link](https://www.conventionalcommits.org/pt-br/v1.0.0/#mensagem-de-commit-com--para-chamar-a-aten%C3%A7%C3%A3o-para-quebra-a-compatibilidade)): ``` ## Mensagem de commit com ! para chamar a atenção para quebra a compatibilidade refactor!: remove suporte para Node 6 ``` Which translates to ``` ## Commit message with ! to draw attention to breaking change refactor!: removes support for Node 6 ``` Maybe this example is not adequate since refactoring means changing the internal structure _without modifying observable behavior_ (Refactoring, Kent Beck). Refactor and breaking changes shouldn't be in the same commit/PR, right? I'm no expert in software development or refactoring, I'm still learning things. So I'm if I understood something, please tell me :D
GiteaMirror commented 2026-02-17 11:49:58 -06:00
Author
Owner
Copy Link

@yudi-azvd commented on GitHub (Jul 1, 2022):

I've just read the summary and it says "a BREAKING CHANGE can be part of commits of any type".

Is this correct even for refactor: type? Can someone explain why?

Also, the reasoning presented in my previous comment was accepted in this PR.

@yudi-azvd commented on GitHub (Jul 1, 2022): I've just read the [summary](https://www.conventionalcommits.org/en/v1.0.0/#summary) and it says "a BREAKING CHANGE can be part of commits of any _type_". Is this correct even for `refactor:` type? Can someone explain why? Also, the reasoning presented in my previous comment was accepted in this [PR](https://github.com/conventional-commits/conventionalcommits.org/pull/350).
GiteaMirror commented 2026-02-17 11:49:59 -06:00
Author
Owner
Copy Link

@javier-godoy commented on GitHub (Jul 1, 2022):

See #229

@javier-godoy commented on GitHub (Jul 1, 2022): See #229
GiteaMirror commented 2026-02-17 11:50:00 -06:00
Author
Owner
Copy Link

@yudi-azvd commented on GitHub (Jul 5, 2022):

Ok... i've read it. Should I open a PR correcting it?

@yudi-azvd commented on GitHub (Jul 5, 2022): Ok... i've read it. Should I open a PR correcting it?
GiteaMirror commented 2026-02-17 11:50:01 -06:00
Author
Owner
Copy Link

@damianopetrungaro commented on GitHub (Jul 5, 2022):

Sure @yudi-azvd ! Feel free to open a PR suggesting a better example! Thanks for noticing it as well :D

@damianopetrungaro commented on GitHub (Jul 5, 2022): Sure @yudi-azvd ! Feel free to open a PR suggesting a better example! Thanks for noticing it as well :D
GiteaMirror commented 2026-02-17 11:50:02 -06:00
Author
Owner
Copy Link

@yudi-azvd commented on GitHub (Jul 5, 2022):

Ok :D One more thing. When correcting, should I modify v1.0.0/index.pt-br.md or create a new doc in, say, v1.0.1/...?

@yudi-azvd commented on GitHub (Jul 5, 2022): Ok :D One more thing. When correcting, should I modify `v1.0.0/index.pt-br.md` or create a new doc in, say, `v1.0.1/...`?
GiteaMirror commented 2026-02-17 11:50:03 -06:00
Author
Owner
Copy Link

@yudi-azvd commented on GitHub (Jul 6, 2022):

@damianopetrungaro I don't know if you speak portuguese, but can you take a look at #458? Or maybe assign a reviewer who speaks portuguese

@yudi-azvd commented on GitHub (Jul 6, 2022): @damianopetrungaro I don't know if you speak portuguese, but can you take a look at #458? Or maybe assign a reviewer who speaks portuguese
GiteaMirror commented 2026-02-17 11:50:04 -06:00
Author
Owner
Copy Link

@yudi-azvd commented on GitHub (Sep 7, 2022):

Closed by #458.

@yudi-azvd commented on GitHub (Sep 7, 2022): Closed by #458.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
discussion
enhancement
greenkeeper
help wanted
meeting-agenda
operations
process
pull-request
Mirrored from GitHub Pull Request
 question
suggestion
support
triaged
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/conventionalcommits.org#151
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?