github-starred/conventionalcommits.org
2
0
Fork 0
mirror of https://github.com/conventional-commits/conventionalcommits.org.git synced 2026-03-12 02:17:21 -05:00
Code Issues 153 Packages Projects Releases Wiki Activity

[PR #350] [MERGED] fix: replace "refactor!" with "feat!" #458

New Issue
Closed
opened 2026-02-17 12:04:22 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-17 12:04:22 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/conventional-commits/conventionalcommits.org/pull/350
Author: @SergiyKolesnikov
Created: 3/17/2021
Status: ✅ Merged
Merged: 3/17/2021
Merged by: @damianopetrungaro

Base: master ← Head: fix-refactor-breaking-change

📝 Commits (1)

  • cd3b8e1 fix: replace "refactor!" with "feat!"

📊 Changes

1 file changed (+3 additions, -3 deletions)

View changed files

📝 content/next/index.md (+3 -3)

📄 Description

Refactoring by definition "is the process of changing a software system in such a way that it does not alter the external behavior of the code..." So, a refactoring cannot introduce a breaking change, otherwise it is not a refactoring anymore. Using refactor commit type and the breaking change marker ! is a contradiction.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/conventional-commits/conventionalcommits.org/pull/350 **Author:** [@SergiyKolesnikov](https://github.com/SergiyKolesnikov) **Created:** 3/17/2021 **Status:** ✅ Merged **Merged:** 3/17/2021 **Merged by:** [@damianopetrungaro](https://github.com/damianopetrungaro) **Base:** `master` ← **Head:** `fix-refactor-breaking-change` --- ### 📝 Commits (1) - [`cd3b8e1`](https://github.com/conventional-commits/conventionalcommits.org/commit/cd3b8e1abec9894d60160031346890dce1d2a3bd) fix: replace "refactor!" with "feat!" ### 📊 Changes **1 file changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `content/next/index.md` (+3 -3) </details> ### 📄 Description Refactoring by definition "is the process of changing a software system in such a way that it does not alter the external behavior of the code..." So, a refactoring cannot introduce a breaking change, otherwise it is not a refactoring anymore. Using `refactor` commit type and the breaking change marker `!` is a contradiction. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-17 12:04:22 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
discussion
enhancement
greenkeeper
help wanted
meeting-agenda
operations
process
pull-request
Mirrored from GitHub Pull Request
 question
suggestion
support
triaged
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/conventionalcommits.org#458
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?