github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #8162] [MERGED] fix(two-factor): handle undefined options verifyTwoFactor #7789

New Issue
Closed
opened 2026-03-13 13:49:14 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 13:49:14 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/8162
Author: @okisdev
Created: 2/26/2026
Status: ✅ Merged
Merged: 2/27/2026
Merged by: @himself65

Base: canary ← Head: fix(two-factor)/handle-undefined-options-verifyTwoFactor

📝 Commits (1)

  • da361e8 fix(two-factor): handle undefined options verifyTwoFactor

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 packages/better-auth/src/plugins/two-factor/verify-two-factor.ts (+1 -1)

📄 Description

This PR fixes when twoFactor() is called without arguments, plugin.options is undefined.

Before:

plugins: [
    twoFactor({}),
],

After:

plugins: [
    twoFactor(),
],

Summary by cubic

Fixes a runtime error in two-factor verification when the plugin is used without options. We now read plugin.options?.trustDeviceMaxAge and fall back to the default cookie max age, so twoFactor() works without arguments.

Written for commit da361e8efc. Summary will update on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/8162 **Author:** [@okisdev](https://github.com/okisdev) **Created:** 2/26/2026 **Status:** ✅ Merged **Merged:** 2/27/2026 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `fix(two-factor)/handle-undefined-options-verifyTwoFactor` --- ### 📝 Commits (1) - [`da361e8`](https://github.com/better-auth/better-auth/commit/da361e8efc95d156f5b5e65571728d9d9e4760a2) fix(two-factor): handle undefined options verifyTwoFactor ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/plugins/two-factor/verify-two-factor.ts` (+1 -1) </details> ### 📄 Description This PR fixes when `twoFactor()` is called without arguments, `plugin.options` is undefined. Before: ```ts plugins: [ twoFactor({}), ], ``` After: ```ts plugins: [ twoFactor(), ], ``` <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Fixes a runtime error in two-factor verification when the plugin is used without options. We now read plugin.options?.trustDeviceMaxAge and fall back to the default cookie max age, so twoFactor() works without arguments. <sup>Written for commit da361e8efc95d156f5b5e65571728d9d9e4760a2. Summary will update on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 13:49:14 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#7789
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?