github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #7789] [CLOSED] Add allowedAttempts setting #24455

New Issue
Closed
opened 2026-04-15 22:22:43 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 22:22:43 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/7789
Author: @vadim-works
Created: 2/4/2026
Status: ❌ Closed

Base: canary ← Head: feat/issue-1-add-allowed-attempts

📝 Commits (1)

📊 Changes

3 files changed (+294 additions, -5 deletions)

View changed files

📝 docs/content/docs/plugins/magic-link.mdx (+2 -0)
📝 packages/better-auth/src/plugins/magic-link/index.ts (+31 -4)
📝 packages/better-auth/src/plugins/magic-link/magic-link.test.ts (+261 -1)

📄 Description

Close #1

Summary by cubic

Add an allowedAttempts setting to the Magic Link plugin to control how many times a token can be verified. Default is 1; exceeding the limit deletes the token and redirects with ?error=ATTEMPTS_EXCEEDED.

  • New Features
    • Added allowedAttempts option (default 1; supports Infinity for unlimited), with attempt count stored and incremented per verify.
    • Verification blocks and deletes the token when the limit is reached; existing expiry checks still apply.
    • Updated docs and added tests for default, custom values (e.g., 3), Infinity, and expired tokens.

Written for commit fb2ec774e5. Summary will update on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/7789 **Author:** [@vadim-works](https://github.com/vadim-works) **Created:** 2/4/2026 **Status:** ❌ Closed **Base:** `canary` ← **Head:** `feat/issue-1-add-allowed-attempts` --- ### 📝 Commits (1) - [`fb2ec77`](https://github.com/better-auth/better-auth/commit/fb2ec774e5ee4a288355249be0f8d6659545cb76) Add allowedAttempts setting #1 ### 📊 Changes **3 files changed** (+294 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `docs/content/docs/plugins/magic-link.mdx` (+2 -0) 📝 `packages/better-auth/src/plugins/magic-link/index.ts` (+31 -4) 📝 `packages/better-auth/src/plugins/magic-link/magic-link.test.ts` (+261 -1) </details> ### 📄 Description Close #1 <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Add an allowedAttempts setting to the Magic Link plugin to control how many times a token can be verified. Default is 1; exceeding the limit deletes the token and redirects with ?error=ATTEMPTS_EXCEEDED. - **New Features** - Added allowedAttempts option (default 1; supports Infinity for unlimited), with attempt count stored and incremented per verify. - Verification blocks and deletes the token when the limit is reached; existing expiry checks still apply. - Updated docs and added tests for default, custom values (e.g., 3), Infinity, and expired tokens. <sup>Written for commit fb2ec774e5ee4a288355249be0f8d6659545cb76. Summary will update on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 22:22:43 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#24455
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?