github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 22:32:01 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #5979] [CLOSED] fix(email-verification): make session optional for change email flow #6358

New Issue
Closed
opened 2026-03-13 12:55:53 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 12:55:53 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/5979
Author: @tomdenboon
Created: 11/14/2025
Status: ❌ Closed

Base: main ← Head: fix/optional-session-email-change

📝 Commits (10+)

  • e5c0775 chore: add --continue on test script (#5472)
  • f73b244 chore: remove an unused option (#5484)
  • 5bc2604 fix: rename sha to branch and made it canary by default (#5491)
  • 4786ec3 docs: remove server route handler instructions from TanStack Start Integration Guide (#5488)
  • 80e4a7a demo: add passkey login (#5399)
  • 56155f9 docs: add prisma postgres to community dialects section (#5492)
  • a8ef888 docs: clarify requireEmailVerification and sendOnSignIn behavior (#5402)
  • 8f69993 chore: add stateless auth demo (#5485)
  • b2255ba chore(deps): update dependency hono to v4.10.2 [security] (#5490)
  • dda1ec2 fix(admin): validate admin role updates against the configured roles to prevent setting a non-existent role (#4842)

📊 Changes

1008 files changed (+68030 additions, -25695 deletions)

View changed files

➖ .github/workflows/branch-rules.yml (+0 -36)
➕ .github/workflows/cherry-pick-to-main.yml (+325 -0)
📝 .github/workflows/ci.yml (+140 -74)
📝 .github/workflows/e2e.yml (+6 -5)
➖ .github/workflows/main-protect.yml (+0 -18)
📝 .github/workflows/preview.yml (+2 -2)
📝 .github/workflows/release.yml (+11 -6)
📝 CONTRIBUTING.md (+30 -6)
📝 README.md (+1 -1)
📝 biome.json (+7 -4)
➕ demo/expo/.env.example (+7 -0)
➕ demo/expo/.gitignore (+20 -0)
➕ demo/expo/README.md (+15 -0)
➕ demo/expo/app.config.ts (+55 -0)
➕ demo/expo/assets/bg-image.jpeg (+0 -0)
➕ demo/expo/assets/fonts/SpaceMono-Regular.ttf (+0 -0)
➕ demo/expo/assets/icon.png (+0 -0)
➕ demo/expo/assets/images/adaptive-icon.png (+0 -0)
➕ demo/expo/assets/images/favicon.png (+0 -0)
➕ demo/expo/assets/images/logo.png (+0 -0)

...and 80 more files

📄 Description

Summary by cubic

Makes email change verification work without an active session, fixing confirmation links opened from a different device. Also adds an Expo demo and streamlines CI with an automated cherry-pick workflow.

  • New Features

    • Added Expo example app hosting Better Auth via Expo API Router.
    • Supports email/password and GitHub/Google sign-in with SecureStore-based session storage.
    • Includes Tailwind/NativeWind UI components and example env/config files.

  • Refactors

    • Reworked GitHub Actions: added scheduled cherry-pick-to-main; removed branch rules and main-protect; pinned action versions; updated cache to v4.3.0.
    • Updated CI/release/e2e/preview workflows for consistency and reliability.
    • Bumped Biome schema to 2.2.6 and enabled organizeImports; added stricter lint rules.
    • Standardized wording to “authentication framework”; cleaned and reordered Next.js demo code; added Apple env placeholders.

Written for commit 7e815c5dc1. Summary will update automatically on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/5979 **Author:** [@tomdenboon](https://github.com/tomdenboon) **Created:** 11/14/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/optional-session-email-change` --- ### 📝 Commits (10+) - [`e5c0775`](https://github.com/better-auth/better-auth/commit/e5c077565351b6c6b337d47c1ab882d6decf3ca1) chore: add `--continue` on test script (#5472) - [`f73b244`](https://github.com/better-auth/better-auth/commit/f73b244cb53d8529a44f64dc1fe75f7b66420797) chore: remove an unused option (#5484) - [`5bc2604`](https://github.com/better-auth/better-auth/commit/5bc26041979f913afa7cc981291ad769d47b549f) fix: rename `sha` to `branch` and made it `canary` by default (#5491) - [`4786ec3`](https://github.com/better-auth/better-auth/commit/4786ec35cda98d057996b3942aa0c71a87b88916) docs: remove server route handler instructions from TanStack Start Integration Guide (#5488) - [`80e4a7a`](https://github.com/better-auth/better-auth/commit/80e4a7a8ae44a00fcd9584ebd9b5c75728bc66d9) demo: add passkey login (#5399) - [`56155f9`](https://github.com/better-auth/better-auth/commit/56155f9dad7e3a7912172929dce1e52192be650b) docs: add prisma postgres to community dialects section (#5492) - [`a8ef888`](https://github.com/better-auth/better-auth/commit/a8ef8884a8a7dbaf16413cf7e394931d7c31f7ed) docs: clarify requireEmailVerification and sendOnSignIn behavior (#5402) - [`8f69993`](https://github.com/better-auth/better-auth/commit/8f699938230d202301a37605c324435f1170cb98) chore: add stateless auth demo (#5485) - [`b2255ba`](https://github.com/better-auth/better-auth/commit/b2255ba421b67a59cb043a58fd7e63660241b1c0) chore(deps): update dependency hono to v4.10.2 [security] (#5490) - [`dda1ec2`](https://github.com/better-auth/better-auth/commit/dda1ec2f835a24e6ab50184d1c8682bf17564ff3) fix(admin): validate admin role updates against the configured roles to prevent setting a non-existent role (#4842) ### 📊 Changes **1008 files changed** (+68030 additions, -25695 deletions) <details> <summary>View changed files</summary> ➖ `.github/workflows/branch-rules.yml` (+0 -36) ➕ `.github/workflows/cherry-pick-to-main.yml` (+325 -0) 📝 `.github/workflows/ci.yml` (+140 -74) 📝 `.github/workflows/e2e.yml` (+6 -5) ➖ `.github/workflows/main-protect.yml` (+0 -18) 📝 `.github/workflows/preview.yml` (+2 -2) 📝 `.github/workflows/release.yml` (+11 -6) 📝 `CONTRIBUTING.md` (+30 -6) 📝 `README.md` (+1 -1) 📝 `biome.json` (+7 -4) ➕ `demo/expo/.env.example` (+7 -0) ➕ `demo/expo/.gitignore` (+20 -0) ➕ `demo/expo/README.md` (+15 -0) ➕ `demo/expo/app.config.ts` (+55 -0) ➕ `demo/expo/assets/bg-image.jpeg` (+0 -0) ➕ `demo/expo/assets/fonts/SpaceMono-Regular.ttf` (+0 -0) ➕ `demo/expo/assets/icon.png` (+0 -0) ➕ `demo/expo/assets/images/adaptive-icon.png` (+0 -0) ➕ `demo/expo/assets/images/favicon.png` (+0 -0) ➕ `demo/expo/assets/images/logo.png` (+0 -0) _...and 80 more files_ </details> ### 📄 Description <!-- This is an auto-generated description by cubic. --> ## Summary by cubic Makes email change verification work without an active session, fixing confirmation links opened from a different device. Also adds an Expo demo and streamlines CI with an automated cherry-pick workflow. - **New Features** - Added Expo example app hosting Better Auth via Expo API Router. - Supports email/password and GitHub/Google sign-in with SecureStore-based session storage. - Includes Tailwind/NativeWind UI components and example env/config files. - **Refactors** - Reworked GitHub Actions: added scheduled cherry-pick-to-main; removed branch rules and main-protect; pinned action versions; updated cache to v4.3.0. - Updated CI/release/e2e/preview workflows for consistency and reliability. - Bumped Biome schema to 2.2.6 and enabled organizeImports; added stricter lint rules. - Standardized wording to “authentication framework”; cleaned and reordered Next.js demo code; added Apple env placeholders. <sup>Written for commit 7e815c5dc1e4350c9cca76e8be820d207128485e. Summary will update automatically on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 12:55:53 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#6358
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?