github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #4616] [MERGED] test: add tests to make sure after hook runs after db update #5484

New Issue
Closed
opened 2026-03-13 12:24:32 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 12:24:32 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/4616
Author: @frectonz
Created: 9/12/2025
Status: ✅ Merged
Merged: 9/13/2025
Merged by: @himself65

Base: canary ← Head: fix/after-hooks-runs-after-db-update

📝 Commits (2)

  • 4c11fe5 test: add tests to make sure after hook runs after db update
  • c52fc46 Merge branch 'canary' into fix/after-hooks-runs-after-db-update

📊 Changes

1 file changed (+71 additions, -1 deletions)

View changed files

📝 packages/better-auth/src/db/internal-adapter.test.ts (+71 -1)

📄 Description

closes #4614

Summary by cubic

Adds a test that verifies user.create.after runs after the DB write during sign-up and is called once, closing #4614. It uses in-memory SQLite (Kysely) and fetches the user inside the hook to assert the persisted fields match.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/4616 **Author:** [@frectonz](https://github.com/frectonz) **Created:** 9/12/2025 **Status:** ✅ Merged **Merged:** 9/13/2025 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `fix/after-hooks-runs-after-db-update` --- ### 📝 Commits (2) - [`4c11fe5`](https://github.com/better-auth/better-auth/commit/4c11fe5fd630b7f24ffa9fd265390a1b73def8ec) test: add tests to make sure after hook runs after db update - [`c52fc46`](https://github.com/better-auth/better-auth/commit/c52fc4634b092b2969cae9f8746efbce7ad8092c) Merge branch 'canary' into fix/after-hooks-runs-after-db-update ### 📊 Changes **1 file changed** (+71 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/db/internal-adapter.test.ts` (+71 -1) </details> ### 📄 Description closes #4614 <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Adds a test that verifies user.create.after runs after the DB write during sign-up and is called once, closing #4614. It uses in-memory SQLite (Kysely) and fetches the user inside the hook to assert the persisted fields match. <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 12:24:32 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#5484
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?