github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #5299] [MERGED] chore: combined filter and search operator test #5912

New Issue
Closed
opened 2026-03-13 12:41:05 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 12:41:05 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/5299
Author: @Kinfe123
Created: 10/14/2025
Status: ✅ Merged
Merged: 10/14/2025
Merged by: @himself65

Base: canary ← Head: chore/combined-search-filter

📝 Commits (1)

  • 9c41664 chore: combined filter and search operator test

📊 Changes

1 file changed (+18 additions, -1 deletions)

View changed files

📝 packages/better-auth/src/plugins/admin/admin.test.ts (+18 -1)

📄 Description

this pr is made for making sure both search and filter combnation works on #5295

Summary by cubic

Add a test that proves admin.listUsers supports combining a role=admin filter with an email contains "test" search. Also relax another test to assert users count is >= 2 to avoid brittle failures as data changes.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/5299 **Author:** [@Kinfe123](https://github.com/Kinfe123) **Created:** 10/14/2025 **Status:** ✅ Merged **Merged:** 10/14/2025 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `chore/combined-search-filter` --- ### 📝 Commits (1) - [`9c41664`](https://github.com/better-auth/better-auth/commit/9c4166448ccf4d8ba4a616adcb674dfa7d5d9847) chore: combined filter and search operator test ### 📊 Changes **1 file changed** (+18 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/plugins/admin/admin.test.ts` (+18 -1) </details> ### 📄 Description this pr is made for making sure both search and filter combnation works on #5295 <!-- This is an auto-generated description by cubic. --> ## Summary by cubic Add a test that proves admin.listUsers supports combining a role=admin filter with an email contains "test" search. Also relax another test to assert users count is >= 2 to avoid brittle failures as data changes. <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 12:41:05 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#5912
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?