github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #5912] fix(oidc-provider): oidc_login_prompt not cleared after login #14562

New Issue
Closed
opened 2026-04-13 09:31:46 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 09:31:46 -05:00
Owner
Copy Link

Original Pull Request: https://github.com/better-auth/better-auth/pull/5912

State: closed
Merged: Yes

Closes https://github.com/better-auth/better-auth/issues/4594

Summary by cubic

Fixes the OIDC flow so the oidc_login_prompt cookie is cleared after login, preventing repeated consent prompts. The cookie is now removed once a valid session is detected.

  • Bug Fixes
    • Validate session with getSessionFromCtx and ctx.context.newSession instead of parsing Set-Cookie headers.
    • Clear oidc_login_prompt when a session exists in both mcp and oidc-provider plugins via post-login middleware.
    • Added a unit test that verifies the cookie is cleared after sign-up/login.

Written for commit c173710244. Summary will update automatically on new commits.

**Original Pull Request:** https://github.com/better-auth/better-auth/pull/5912 **State:** closed **Merged:** Yes --- Closes https://github.com/better-auth/better-auth/issues/4594 <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Fixes the OIDC flow so the oidc_login_prompt cookie is cleared after login, preventing repeated consent prompts. The cookie is now removed once a valid session is detected. - **Bug Fixes** - Validate session with getSessionFromCtx and ctx.context.newSession instead of parsing Set-Cookie headers. - Clear oidc_login_prompt when a session exists in both mcp and oidc-provider plugins via post-login middleware. - Added a unit test that verifies the cookie is cleared after sign-up/login. <sup>Written for commit c173710244cda86aa36301a44e809007d1c57279. Summary will update automatically on new commits.</sup> <!-- End of auto-generated description by cubic. -->
GiteaMirror added the pull-request label 2026-04-13 09:31:46 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#14562
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?