github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-24 08:01:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #5204] [MERGED] fix(passkey): wrong Session type being used on passkey #5848

New Issue
Closed
opened 2026-03-13 12:38:54 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 12:38:54 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/5204
Author: @ouwargui
Created: 10/10/2025
Status: ✅ Merged
Merged: 10/10/2025
Merged by: @himself65

Base: canary ← Head: patch-2

📝 Commits (1)

  • a218bb4 fix: wrong Session type being used on passkey

📊 Changes

1 file changed (+1 additions, -2 deletions)

View changed files

📝 packages/better-auth/src/plugins/passkey/client.ts (+1 -2)

📄 Description

Passkey client was using a Session type from Node inspector, so I changed to use the correct Session type.

Summary by cubic

Use the correct Session type in the passkey client (from ../../types, not Node’s inspector) to fix a type mismatch and ensure correct typings in the passkey flow.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/5204 **Author:** [@ouwargui](https://github.com/ouwargui) **Created:** 10/10/2025 **Status:** ✅ Merged **Merged:** 10/10/2025 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `patch-2` --- ### 📝 Commits (1) - [`a218bb4`](https://github.com/better-auth/better-auth/commit/a218bb4da79c95a3042450e3c6124285f61750be) fix: wrong Session type being used on passkey ### 📊 Changes **1 file changed** (+1 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/plugins/passkey/client.ts` (+1 -2) </details> ### 📄 Description Passkey client was using a `Session` type from [Node inspector](https://nodejs.org/api/inspector.html#class-inspectorsession), so I changed to use the correct `Session` type. <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Use the correct Session type in the passkey client (from ../../types, not Node’s inspector) to fix a type mismatch and ensure correct typings in the passkey flow. <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 12:38:54 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#5848
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?