[PR #5848] fix(odic): case when prompt=login #14522

New Issue

2026-04-13T09:31:08-05:00

GiteaMirror commented

2026-04-13 09:31:08 -05:00

Original Pull Request: https://github.com/better-auth/better-auth/pull/5848

State: closed
Merged: Yes

Summary by cubic

Fixes OIDC prompt=login handling to always reauthenticate, prevents redirect loops after login, and adds spec‑compliant prompt parsing. Adds safer cookie parsing and a more robust login redirect URL.

Bug Fixes
- Force reauth when prompt=login or no session; set signed cookie and redirect to the login page.
- After login, mark oidcLoginPromptHandled to continue authorization without another redirect.
- Parse and validate prompt per OIDC (login/consent/select_account/none); reject invalid combos with InvalidRequest.
- Safely parse oidc_login_prompt cookie and preserve query params when redirecting; handle empty query strings.

^{Written for commit 8d7b28d3d5. Summary will update automatically on new commits.}

**Original Pull Request:** https://github.com/better-auth/better-auth/pull/5848 **State:** closed **Merged:** Yes ---  ## Summary by cubic Fixes OIDC prompt=login handling to always reauthenticate, prevents redirect loops after login, and adds spec‑compliant prompt parsing. Adds safer cookie parsing and a more robust login redirect URL. - **Bug Fixes** - Force reauth when prompt=login or no session; set signed cookie and redirect to the login page. - After login, mark oidcLoginPromptHandled to continue authorization without another redirect. - Parse and validate prompt per OIDC (login/consent/select_account/none); reject invalid combos with InvalidRequest. - Safely parse oidc_login_prompt cookie and preserve query params when redirecting; handle empty query strings. <sup>Written for commit 8d7b28d3d510cf0621b000843d305f55021e37bc. Summary will update automatically on new commits.</sup>

GiteaMirror added the pull-request label 2026-04-13 09:31:08 -05:00

GiteaMirror closed this issue

2026-04-13 09:31:09 -05:00

Sign in to join this conversation.

Branches Tags

dependabot/npm_and_yarn/demo/electron/demo-minor-patch-64ddd28b13

dependabot/github_actions/github-actions-87ac2fb667

2026-10-17/fix/oidc-token-validation

changeset-release/main

main

starsling/prisma-migration-reset

starsling/drizzle-kit-push-util

2026-10-16/fix/discord-profile-types

2026-10-16/fix/spotify-profile-types

2026-10-16/fix/paybin-profile-types

2026-10-16/fix/notion-profile-types

2026-10-16/fix/kakao-profile-types

2026-10-16/fix/linear-profile-types

2026-10-16/fix/gitlab-profile-types

2026-10-16/fix/twitter-profile-types

2026-10-16/fix/slack-profile-types

2026-10-16/fix/zoom-login-types

2026-10-16/fix/twitch-profile-types

2026-10-16/fix/google-profile-types

2026-10-16/fix/dropbox-profile-types

2026-10-16/fix/huggingface-profile-types

2026-10-16/fix/cognito-profile-data

2026-10-16/fix/polar-profile-data

2026-10-15/fix/github-profile-types

2026-10-16/fix/patreon-profile-data

2026-10-16/fix/apple-profile-types

docs-sync/next

2026-10-16/fix/paypal-profile-types

2026-10-16/fix/roblox-profile-types

2026-10-16/fix/railway-profile-types

2026-10-16/fix/naver-profile-types

2026-10-16/fix/facebook-profile-types

2026-10-16/fix/vk-profile-types

2026-10-16/fix/linkedin-profile-types

2026-10-16/fix/microsoft-token-claims

2026-10-16/fix/kick-profile-types

feat/oauth-provider-consent-time-client-ownership

2026-10-13/fix/schema-validation-recovery

gus/oauth-provider-client-secret-expiry

feat/id-token-issued-nonce

gus/prisma-insensitive-keyed-update

gus/prisma-mongodb-regex-escape

gus/prisma-mongodb-eq-null-unset

dependabot/npm_and_yarn/undici-8.11.2

dependabot/npm_and_yarn/next-16.3.8

dependabot/npm_and_yarn/modelcontextprotocol/client-2.2.0

gus/introspect-hint-fallback

refactor/oauth-provider-rotation-precheck

gus/sso-email-less-profiles

gus/sso-remove-dead-acs-lookup

changeset-release/v1.6.x

v1.6.x

2026-10-13/feat/integrate-rate-limit-engine

2026-08-12/feat/add-rate-limit-engine

2026-10-03/fix/stripe-redirect-urls

2026-10-03/fix/oauth-endpoint-urls

2026-10-03/fix/sso-callback-urls

2026-10-03/fix/authentication-urls

2026-10-03/fix/social-provider-urls

2026-10-03/feat/url-path-composition

gus/workerd-static-async-hooks

dependabot/npm_and_yarn/demo/electron/demo-minor-patch-f5235d3538

2026-10-10/test/d1-migration-race

2026-10-10/fix/api-key-verification-errors

dependabot/npm_and_yarn/simplewebauthn/server-13.3.2

fix/oauth-callback-token-exchange-logging

2026-10-01/feat/http-hook-lifecycle

fix/core-retry-failed-init

fix/magic-link-verify-redirect-session-errors

fix/session-cache-null-user

fix/session-refresh-post-json-body

feat/ssrf-fetch-boundary

docs/device-approval-context

fix/homepage-demo-video-loading

2026-09-26/feat/jwt-jwk-alg

2026-09-25/fix/avoid-duplicate-schema-output

backport-11283-to-v1.6.x

backport-11290-to-v1.6.x

2026-09-19/fix/stripe-schedule-billing-anchor

2026-09-16/feat/host-cookie-security

backport-11224-to-v1.6.x

2026-09-17/fix/propagate-sign-out-errors

2026-09-09/fix/expo-utf8-storage-chunks

docs/1-7-account-cleanup-guide

fix/react-server-snapshot

fix/oauth-provider-dcr-grants

fix/mongo-objectid-normalize

fix/cookies-host-prefix

fix/two-factor-enable-race

fix/oauth-state-ttl

feat/schema-validation

fix/sso-discovery-ssrf-guard

fix/one-tap-nonce

fix/optional-atomic-adapter-methods

feat/provider-scoped-accounts

2026-09-04/fix/remove-identity-warning

2026-09-04/refactor/account-identity-scope

2026-09-04/fix/mixed-identity-remediation

2026-09-04/test/cloudflare-strict-lib-check

2026-08-27/docs/add-markdown-routes

2026-08-27/refactor/share-api-method-rendering

2026-08-26/feat/versioned-docs

feat/adapter-migration-boundary

feat/account-identity-plan-reporting

2026-08-22/fix/respect-configured-logger

2026-08-19/fix/mysql-disabled-index-introspection

2026-08-18/refactor/simplify-cloudflare-fixture

2026-08-19/ci/stabilize-mssql-startup

docs/1-7-release

2026-08-14/fix/standardize-plugin-types

2026-08-13/fix/acr-values-voluntary

refactor/device-authorization-oauth-boundary

2026-08-11/fix/api-key-rate-limit-window

feat/oauth-provider-custom-subject

pr-9793-merge

2026-07-31/chore/bump-better-call

2026-07-30/chore/upgrade-better-call

2026-07-30/fix/nextjs-rsc-session-refresh

2026-07-29/refactor/centralize-placeholder-email-generation

refactor/oauth-client-application-type

2026-07-28/fix/anonymous-oauth-proxy-linking

feat/agent-feedback-endpoint

fix/oauth-provider-session-deletion

feat/scim-demo-workflow

feat/scim-active-user-link

feat/sso-provider-user-resolution

feat/identity-provider-accounts

feat/oauth-provider-remove-silence-warnings

changeset-release/release/vercel-announcement

release/vercel-announcement

2026-06-29/docs/optimize-og-images

feat/yandex-social-provider

codex/pr-10225-next-comments

fix/phone-number-disable-input

perf/router-build-once

fix/oauth-user-provisioning-fields

codex/ignore-compose-override-spellcheck

2026-06-19/fix/stripe-org-reference-scope

feat/webhooks

feat/baseurl-canonical-serving-split

feat/magic-link-expires-in

fix/esbuild-security-bump

chore/sync-main-to-next-20260615

chore/revert-10053

codex/fix-expo-sdk56-dynamic-import

refactor/oauth-provider-client-authentication-module

fix/oauth-no-store-headers

claude/slack-update-stripe-docs-consistency-8Sc0w

local/fix-invite-accept-idempotency

docs/beta-mdx-component-fallback

fix/dependabot-hono-shell-quote

codex/stateless-account-cookie-resolution

fix/admin-create-user-role-escalation

feat/oauth-provider-oidc-acr

refactor/sign-in-challenges

refactor/optional-kysely-dependency

2026-06-06/chore/kysely-changeset

copilot/fix-code-review-comment

2026-06-02/fix/next-cookies-defer-rsc

feat/oauth-contribution-protocol

ping-maxwell/c-ping-maxwell/fix-kysely-adapter-core-utils-string-resolution-68c5

temp/server-only-test

2026-05-31/refactor/kysely-joins-json-helpers

2026-04-29/feat/google-include-granted-scopes

2026-04-29/fix/oauth-account-scope-semantics

fix/oauth-callback-path-declarative

2026-05-31/fix/sqlite-dialect-affected-rows

fix/next-cookie-separator

2026-05-29/fix/last-login-method-cookie-prefix

ping-maxwell/c-ping-maxwell/fix-error-link-apostrophe-f89a

client-assertions-main

2026-05-15/ci/fix-sqlite-abi-mismatch

2026-05-15/fix/organization-team-add-cascade

2026-05-15/fix/parse-set-cookie-value-validation

2026-05-13/feat/captcha-wildcard-endpoints

fix/i18n-before-hook-translation

fix/disable-migration-generate

2026-05-10/fix/cookie-drain-order

2026-05-10/feat/hooks-finally

2026-05-09/fix/cookie-drain-order

2026-05-09/feat/hooks-finally

2026-05-08/feat/register-before-send

fix/stripe/subscription-data-merge

2026-05-01/chore/pnpm-v11-harden

chore/pnpm-v11

2026-04-27/fix/nextcookies-idempotent-writes

2026-04-26/fix/harden-proxy-host-validation

2026-04-26/refactor/stripe-callback-signature-cleanup

2026-04-26/fix/stripe-subscription-callback-timing

2026-04-11/fix/sveltekit-app-modules

feat/open-api-zod-contract

feat/oauth-idp-initiated-bounce

2026-04-21/fix/oauth-rfc-input-validation

fix/two-factor-identity-guard

fix/resource

feat/emailpassword-authorize

feat/oauth-provider-at-hash-v2

fix/release-grep-fallback

claude/address-review-comments-JhFLr

feat/async-auth

fix/two-factor-totp-verified-enrollment

feat/plugin-ui

codex/blog-1-6-release-post

2026-04-06/fix/type-any-guards

2026-04-05/chore/downgrade-better-call

2026-04-04/ci/skip-vercel-fork-prs

2026-03-28/ci/add-autofix-ci

chore/release-preview-script

himself65/2026/02/19/role

2026-03-20/docs/improve-website

v1.5.x

2026-03-20/fix/anonymous-onlinkaccount-expo

2026-02-17/fix/anonymous-link-state

fix/8607-saml-inresponseto

fix/8549-scim-patch-noop

v1.4.x

refactor/migration-snapshot-tests

worktree-magic-link-additional-data

chore/migrate-build-to-rollup

worktree-fix-dynamic-baseurl-8447

2026-03-06/chore/public-api-check

fix/close-8156-regression-test

fix/secondary-storage-json-error-handling

himself65/verification-namespace

cursor/issue-8307-validation-79a3

himself65/2026/01/30/error-mdx

v1.4.x-staging

fix/email-otp-user

fix/restrict-full-organization-access-roles

himself65/2026/02/12/count

himself65/2026/02/04/define-plugin

2026-02-04/feat/add-pluralize

cursor/better-auth-js-integration-ec21

cursor/expo-state-mismatch-394c

2026-02-01/fix/org-update-role-sync-members

cursor/issue-7607-investigation-e146

cursor/email-generation-helper-0ff6

himself65/2026/01/21/avoid-spread-operator

himself65/2026/01/14/cli

claude/slack-add-advanced-useplural-WHKYL

feat/hooks-pos

feat/2fa-phone

feat/2fa

fix/rotation

fix/username-check

v1.3.x

refactor/organization

feat/multiple-client-ids-social-providers

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/better-auth#14522

[PR #5848] fix(odic): case when prompt=login #14522

Summary by cubic

[PR #5848] fix(odic): case when `prompt=login` #14522