github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 14:21:55 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #5182] [MERGED] fix: ensure falsy values are valid default values #5831

New Issue
Closed
opened 2026-03-13 12:38:01 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 12:38:01 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/5182
Author: @ocherry341
Created: 10/9/2025
Status: ✅ Merged
Merged: 10/9/2025
Merged by: @Bekacru

Base: canary ← Head: fix/parse-input-data

📝 Commits (1)

  • 2b3a001 fix(parse-input-data): ensure falsy values are valid default values

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 packages/better-auth/src/db/schema.ts (+2 -2)

📄 Description

What's Changed and Why

This PR resolves a bug where fields with a falsy defaultValue, specifically 0 or an empty string (""), were incorrectly skipped during the data parsing process.

Relevant Context or Background

This validation logic is crucial for ensuring that field configurations are respected when initializing data for new resources. Incorrectly skipping 0 or "" as default values can lead to unexpected behavior in downstream logic that depends on these fields being present or having their configured default, rather than being entirely absent.

Breaking Changes or Deprecations

None.

Summary by cubic

Fixes parseInputData so falsy default values (0 and "") are applied instead of skipped. This ensures fields initialize with their configured defaults when input is disabled or on create.

  • Bug Fixes
    • Use defaultValue !== undefined instead of a truthy check in both branches of parseInputData.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/5182 **Author:** [@ocherry341](https://github.com/ocherry341) **Created:** 10/9/2025 **Status:** ✅ Merged **Merged:** 10/9/2025 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `canary` ← **Head:** `fix/parse-input-data` --- ### 📝 Commits (1) - [`2b3a001`](https://github.com/better-auth/better-auth/commit/2b3a001e7d822b85e8d20cffc35332bab85a6c66) fix(parse-input-data): ensure falsy values are valid default values ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/db/schema.ts` (+2 -2) </details> ### 📄 Description ### What's Changed and Why This PR resolves a bug where fields with a **falsy** `defaultValue`, specifically `0` or an empty string (`""`), were incorrectly skipped during the data parsing process. ### Relevant Context or Background This validation logic is crucial for ensuring that field configurations are respected when initializing data for new resources. Incorrectly skipping `0` or `""` as default values can lead to unexpected behavior in downstream logic that depends on these fields being present or having their configured default, rather than being entirely absent. ### Breaking Changes or Deprecations None. <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Fixes parseInputData so falsy default values (0 and "") are applied instead of skipped. This ensures fields initialize with their configured defaults when input is disabled or on create. - **Bug Fixes** - Use `defaultValue !== undefined` instead of a truthy check in both branches of parseInputData. <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 12:38:01 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#5831
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?