github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 14:21:55 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #5831] chore(passkey): use error codes in passkey client actions #14505

New Issue
Closed
opened 2026-04-13 09:30:37 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 09:30:37 -05:00
Owner
Copy Link

Original Pull Request: https://github.com/better-auth/better-auth/pull/5831

State: closed
Merged: Yes

Just noticed that no error codes were used here, which makes handling i18n of these errors inconsistent compared to other actions. Ofc one could use the WebAuthnErrorCodes but it just feels like a style break and edge cases are still not covered this way.

Also the registerPasskey action had a missing final return because in the try block data is only returned by this if statement:

if (!verified.data) {
  return verified;
}

Which led to an awkward | undefined return type when calling the function in the client. To get rid of the undefined you'd need to do something like this:
const { error } = (await authClient.passkey.addPasskey({ name: passkeyName })) ?? {};

I also noticed that the PASSKEY_ERROR_CODES were not exported. So I also added them.

**Original Pull Request:** https://github.com/better-auth/better-auth/pull/5831 **State:** closed **Merged:** Yes --- Just noticed that no error codes were used here, which makes handling i18n of these errors inconsistent compared to other actions. Ofc one could use the `WebAuthnErrorCodes` but it just feels like a style break and edge cases are still not covered this way. Also the `registerPasskey` action had a missing final return because in the `try` block data is only returned by this if statement: ``` if (!verified.data) { return verified; } ``` Which led to an awkward `| undefined` return type when calling the function in the client. To get rid of the undefined you'd need to do something like this: `const { error } = (await authClient.passkey.addPasskey({ name: passkeyName })) ?? {};` I also noticed that the `PASSKEY_ERROR_CODES` were not exported. So I also added them.
GiteaMirror added the pull-request label 2026-04-13 09:30:37 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#14505
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?