github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 23:52:05 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #5057] [CLOSED] feat: implement timing attack protection for authentication endpoints #5745

New Issue
Closed
opened 2026-03-13 12:34:04 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 12:34:04 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/5057
Author: @himself65
Created: 10/2/2025
Status: ❌ Closed

Base: canary ← Head: himself65/2025/10/02/auth

📝 Commits (1)

  • 14d052a feat: implement timing attack protection for authentication endpoints

📊 Changes

4 files changed (+114 additions, -0 deletions)

View changed files

📝 packages/better-auth/src/api/to-auth-endpoints.test.ts (+41 -0)
📝 packages/better-auth/src/api/to-auth-endpoints.ts (+38 -0)
➕ packages/better-auth/src/context/timing.ts (+22 -0)
📝 packages/better-auth/src/types/options.ts (+13 -0)

📄 Description

Summary by cubic

Adds timing attack protection to auth endpoints by delaying fast error responses to match the average success time per endpoint. Enabled by default via advanced.enableTimingProtection to reduce information leaks during auth flows.

  • New Features
    • Track per-endpoint successful execution time using a moving average (per auth instance via WeakMap).
    • Delay error responses when they are faster than the tracked average for that endpoint.
    • New advanced.enableTimingProtection option (default true) to allow opting out.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/5057 **Author:** [@himself65](https://github.com/himself65) **Created:** 10/2/2025 **Status:** ❌ Closed **Base:** `canary` ← **Head:** `himself65/2025/10/02/auth` --- ### 📝 Commits (1) - [`14d052a`](https://github.com/better-auth/better-auth/commit/14d052ad675b6382b277a8b1f04503c96d0daea8) feat: implement timing attack protection for authentication endpoints ### 📊 Changes **4 files changed** (+114 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/api/to-auth-endpoints.test.ts` (+41 -0) 📝 `packages/better-auth/src/api/to-auth-endpoints.ts` (+38 -0) ➕ `packages/better-auth/src/context/timing.ts` (+22 -0) 📝 `packages/better-auth/src/types/options.ts` (+13 -0) </details> ### 📄 Description <!-- This is an auto-generated description by cubic. --> ## Summary by cubic Adds timing attack protection to auth endpoints by delaying fast error responses to match the average success time per endpoint. Enabled by default via advanced.enableTimingProtection to reduce information leaks during auth flows. - **New Features** - Track per-endpoint successful execution time using a moving average (per auth instance via WeakMap). - Delay error responses when they are faster than the tracked average for that endpoint. - New advanced.enableTimingProtection option (default true) to allow opting out. <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 12:34:04 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#5745
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?