github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 23:52:05 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #5745] [MERGED] docs: fix safeDateConversion to use milliseconds directly #31795

New Issue
Closed
opened 2026-04-17 22:40:23 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-17 22:40:23 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/5745
Author: @himself65
Created: 11/3/2025
Status: ✅ Merged
Merged: 11/3/2025
Merged by: @himself65

Base: canary ← Head: patch-2

📝 Commits (1)

  • 0cc1fd7 Refactor safeDateConversion to use milliseconds directly

📊 Changes

1 file changed (+2 additions, -3 deletions)

View changed files

📝 docs/content/docs/guides/clerk-migration-guide.mdx (+2 -3)

📄 Description

Closes: https://github.com/better-auth/better-auth/pull/5743

Summary by cubic

Fixed the Clerk migration guide’s safeDateConversion example to use millisecond timestamps directly, removing the seconds-to-milliseconds conversion. This matches Clerk’s API and prevents invalid date calculations.

  • Bug Fixes
    • Use new Date(timestamp) to handle millisecond input from Clerk.

Written for commit 0cc1fd7f9c. Summary will update automatically on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/5745 **Author:** [@himself65](https://github.com/himself65) **Created:** 11/3/2025 **Status:** ✅ Merged **Merged:** 11/3/2025 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `patch-2` --- ### 📝 Commits (1) - [`0cc1fd7`](https://github.com/better-auth/better-auth/commit/0cc1fd7f9cf3349b61052e3ac4272e68604868d6) Refactor safeDateConversion to use milliseconds directly ### 📊 Changes **1 file changed** (+2 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `docs/content/docs/guides/clerk-migration-guide.mdx` (+2 -3) </details> ### 📄 Description Closes: https://github.com/better-auth/better-auth/pull/5743 <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Fixed the Clerk migration guide’s safeDateConversion example to use millisecond timestamps directly, removing the seconds-to-milliseconds conversion. This matches Clerk’s API and prevents invalid date calculations. - **Bug Fixes** - Use new Date(timestamp) to handle millisecond input from Clerk. <sup>Written for commit 0cc1fd7f9cf3349b61052e3ac4272e68604868d6. Summary will update automatically on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-17 22:40:23 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#31795
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?