github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #4649] [MERGED] fix: check if user exists before banning the user #5505

New Issue
Closed
opened 2026-03-13 12:25:21 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 12:25:21 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/4649
Author: @anmol-fzr
Created: 9/14/2025
Status: ✅ Merged
Merged: 9/15/2025
Merged by: @himself65

Base: canary ← Head: fix/admin-user-ban-check

📝 Commits (3)

  • 0b472dd Fix: Checks if user exists before banning the user
  • 1fca931 Merge branch 'canary' into fix/admin-user-ban-check
  • 4756dcc test: fix

📊 Changes

2 files changed (+96 additions, -2 deletions)

View changed files

📝 packages/better-auth/src/plugins/admin/admin.test.ts (+85 -2)
📝 packages/better-auth/src/plugins/admin/admin.ts (+11 -0)

📄 Description

Fixes: https://github.com/better-auth/better-auth/issues/4648

Added a simple check before updating the user for banning

  • If user is not found return a 404 NOT_FOUND error

Summary by cubic

Banning a user now verifies the target exists. If not found, it returns 404 NOT_FOUND (USER_NOT_FOUND).

  • Bug Fixes
    • Check user via internalAdapter.findUserById before ban.
    • Keep self-ban guard; nonexistent users are rejected first.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/4649 **Author:** [@anmol-fzr](https://github.com/anmol-fzr) **Created:** 9/14/2025 **Status:** ✅ Merged **Merged:** 9/15/2025 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `fix/admin-user-ban-check` --- ### 📝 Commits (3) - [`0b472dd`](https://github.com/better-auth/better-auth/commit/0b472dd75b2ba608b2e7e88695515617173383b8) Fix: Checks if user exists before banning the user - [`1fca931`](https://github.com/better-auth/better-auth/commit/1fca931400adc0df7338b92454cebce38f98ded6) Merge branch 'canary' into fix/admin-user-ban-check - [`4756dcc`](https://github.com/better-auth/better-auth/commit/4756dcc78572ea646d14c664f58e79c53fa6a948) test: fix ### 📊 Changes **2 files changed** (+96 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/plugins/admin/admin.test.ts` (+85 -2) 📝 `packages/better-auth/src/plugins/admin/admin.ts` (+11 -0) </details> ### 📄 Description Fixes: https://github.com/better-auth/better-auth/issues/4648 Added a simple check before updating the user for banning - If user is not found return a 404 NOT_FOUND error <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Banning a user now verifies the target exists. If not found, it returns 404 NOT_FOUND (USER_NOT_FOUND). - **Bug Fixes** - Check user via internalAdapter.findUserById before ban. - Keep self-ban guard; nonexistent users are rejected first. <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 12:25:21 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#5505
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?