github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 22:32:01 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #3107] [CLOSED] Support multiple valid email OTPs #4649

New Issue
Closed
opened 2026-03-13 11:54:02 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 11:54:02 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/3107
Author: @Bekacru
Created: 6/20/2025
Status: ❌ Closed

Base: main ← Head: codex/fix-issue-1568-in-better-auth

📝 Commits (1)

  • 5a0fe14 feat(email-otp): allow multiple otps

📊 Changes

4 files changed (+195 additions, -79 deletions)

View changed files

📝 packages/better-auth/src/__snapshots__/init.test.ts.snap (+1 -0)
📝 packages/better-auth/src/db/internal-adapter.ts (+28 -0)
📝 packages/better-auth/src/plugins/email-otp/email-otp.test.ts (+12 -1)
📝 packages/better-auth/src/plugins/email-otp/index.ts (+154 -78)

📄 Description

Summary

  • add findVerificationValues to internal adapter
  • add allowMultipleOTPs option
  • handle multiple OTPs when verifying email OTPs
  • test verifying old OTPs when multiple OTPs are allowed

Testing

  • pnpm test (fails: 7 test files failed)

https://chatgpt.com/codex/tasks/task_e_6855b1985f44832b9975c784f3e0346d

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/3107 **Author:** [@Bekacru](https://github.com/Bekacru) **Created:** 6/20/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `codex/fix-issue-1568-in-better-auth` --- ### 📝 Commits (1) - [`5a0fe14`](https://github.com/better-auth/better-auth/commit/5a0fe14f9eda561b180b38fcfd5b993e462d9282) feat(email-otp): allow multiple otps ### 📊 Changes **4 files changed** (+195 additions, -79 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/__snapshots__/init.test.ts.snap` (+1 -0) 📝 `packages/better-auth/src/db/internal-adapter.ts` (+28 -0) 📝 `packages/better-auth/src/plugins/email-otp/email-otp.test.ts` (+12 -1) 📝 `packages/better-auth/src/plugins/email-otp/index.ts` (+154 -78) </details> ### 📄 Description ## Summary - add `findVerificationValues` to internal adapter - add `allowMultipleOTPs` option - handle multiple OTPs when verifying email OTPs - test verifying old OTPs when multiple OTPs are allowed ## Testing - `pnpm test` *(fails: 7 test files failed)* ------ https://chatgpt.com/codex/tasks/task_e_6855b1985f44832b9975c784f3e0346d --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 11:54:02 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#4649
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?