github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 23:52:05 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #4533] [MERGED] fix(organization): checkRolePermission shouldn't be a promise #5432

New Issue
Closed
opened 2026-03-13 12:22:37 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 12:22:37 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/4533
Author: @ping-maxwell
Created: 9/9/2025
Status: ✅ Merged
Merged: 9/9/2025
Merged by: @himself65

Base: canary ← Head: fix/org/check-role-permission-async

📝 Commits (4)

  • 265d66c fix(organization): checkRolePermission shouldn't be a promise
  • e47b618 Merge branch 'canary' into fix/org/check-role-permission-async
  • 3cba992 Merge branch 'canary' into fix/org/check-role-permission-async
  • 3ddf44f Merge branch 'canary' into fix/org/check-role-permission-async

📊 Changes

1 file changed (+1 additions, -3 deletions)

View changed files

📝 packages/better-auth/src/plugins/organization/has-permission.ts (+1 -3)

📄 Description

Summary by cubic

Made clientSideHasPermission synchronous by removing async. This aligns with checkRolePermission (should not be a Promise) and prevents unnecessary awaits and type mismatches.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/4533 **Author:** [@ping-maxwell](https://github.com/ping-maxwell) **Created:** 9/9/2025 **Status:** ✅ Merged **Merged:** 9/9/2025 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `fix/org/check-role-permission-async` --- ### 📝 Commits (4) - [`265d66c`](https://github.com/better-auth/better-auth/commit/265d66cdef8ce4979b0f0e419458131f1ea8d592) fix(organization): `checkRolePermission` shouldn't be a promise - [`e47b618`](https://github.com/better-auth/better-auth/commit/e47b618346a2875490afaaa0353f4f5c03848c61) Merge branch 'canary' into fix/org/check-role-permission-async - [`3cba992`](https://github.com/better-auth/better-auth/commit/3cba9923290511a8b5788dd23a175912f1091f4f) Merge branch 'canary' into fix/org/check-role-permission-async - [`3ddf44f`](https://github.com/better-auth/better-auth/commit/3ddf44f335cf1c9a85a3cb2402c514b57e0d1849) Merge branch 'canary' into fix/org/check-role-permission-async ### 📊 Changes **1 file changed** (+1 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/plugins/organization/has-permission.ts` (+1 -3) </details> ### 📄 Description <!-- This is an auto-generated description by cubic. --> ## Summary by cubic Made clientSideHasPermission synchronous by removing async. This aligns with checkRolePermission (should not be a Promise) and prevents unnecessary awaits and type mismatches. <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 12:22:37 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#5432
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?