github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-24 08:01:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #5432] [MERGED] fix(expo): store normalized cookie name in storage #31605

New Issue
Closed
opened 2026-04-17 22:30:02 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-17 22:30:02 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/5432
Author: @ping-maxwell
Created: 10/20/2025
Status: ✅ Merged
Merged: 10/20/2025
Merged by: @himself65

Base: canary ← Head: fix/expo-secure-store-cookie-name

📝 Commits (3)

  • e75de85 fix(expo): store normalized cookie name in storage
  • ae9e70e add: tests
  • db338d0 Merge branch 'canary' into fix/expo-secure-store-cookie-name

📊 Changes

2 files changed (+44 additions, -2 deletions)

View changed files

📝 packages/expo/src/client.ts (+28 -1)
📝 packages/expo/src/expo.test.ts (+16 -1)

📄 Description

TLDR: Remove colons from secure storage keys.

issue: https://github.com/better-auth/better-auth/issues/5426

linear: https://linear.app/better-auth/issue/ENG-504/fixexpo-colons-in-cookie-names-caused-errors-with-secure-storage

  • tests

Summary by cubic

Fix Expo Secure Store errors caused by colons in cookie names by normalizing keys to use underscores. Stabilizes session storage and avoids crashes. Addresses Linear ENG-504.

  • Bug Fixes
    • Added normalizeCookieName to replace ":" with "_" for storage keys.
    • Wrapped storage get/set with storageAdapter so expoClient always stores normalized cookie names.
    • Removed an unused Image import in the blog page.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/5432 **Author:** [@ping-maxwell](https://github.com/ping-maxwell) **Created:** 10/20/2025 **Status:** ✅ Merged **Merged:** 10/20/2025 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `fix/expo-secure-store-cookie-name` --- ### 📝 Commits (3) - [`e75de85`](https://github.com/better-auth/better-auth/commit/e75de85cd7af2d3352284a08370d75193c12f2cf) fix(expo): store normalized cookie name in storage - [`ae9e70e`](https://github.com/better-auth/better-auth/commit/ae9e70e0050a977de9c25cb35b08eac171551a6f) add: tests - [`db338d0`](https://github.com/better-auth/better-auth/commit/db338d0ef9addb0d74b464da54ba6abff1bd3544) Merge branch 'canary' into fix/expo-secure-store-cookie-name ### 📊 Changes **2 files changed** (+44 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `packages/expo/src/client.ts` (+28 -1) 📝 `packages/expo/src/expo.test.ts` (+16 -1) </details> ### 📄 Description TLDR: Remove colons from secure storage keys. issue: https://github.com/better-auth/better-auth/issues/5426 linear: https://linear.app/better-auth/issue/ENG-504/fixexpo-colons-in-cookie-names-caused-errors-with-secure-storage - [x] tests <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Fix Expo Secure Store errors caused by colons in cookie names by normalizing keys to use underscores. Stabilizes session storage and avoids crashes. Addresses Linear ENG-504. - **Bug Fixes** - Added normalizeCookieName to replace ":" with "_" for storage keys. - Wrapped storage get/set with storageAdapter so expoClient always stores normalized cookie names. - Removed an unused Image import in the blog page. <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-17 22:30:02 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#31605
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?