github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 22:32:01 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #4077] [MERGED] fix: constant time compare #5172

New Issue
Closed
opened 2026-03-13 12:12:54 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 12:12:54 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/4077
Author: @himself65
Created: 8/19/2025
Status: ✅ Merged
Merged: 8/19/2025
Merged by: @himself65

Base: canary ← Head: himself65/2025/08/18/compare

📝 Commits (2)

  • 48883b9 fix: constant time compare
  • a4082d9 fix: constant time compare

📊 Changes

1 file changed (+6 additions, -6 deletions)

View changed files

📝 packages/better-auth/src/crypto/buffer.ts (+6 -6)

📄 Description

An early return value will still lead to a timing attack issue

Related: https://github.com/better-auth/utils/pull/12

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/4077 **Author:** [@himself65](https://github.com/himself65) **Created:** 8/19/2025 **Status:** ✅ Merged **Merged:** 8/19/2025 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `himself65/2025/08/18/compare` --- ### 📝 Commits (2) - [`48883b9`](https://github.com/better-auth/better-auth/commit/48883b9279da95c1c85721c2b8e3212a9864fb8e) fix: constant time compare - [`a4082d9`](https://github.com/better-auth/better-auth/commit/a4082d9603186bc8a3385e8c3641c181f85b9d07) fix: constant time compare ### 📊 Changes **1 file changed** (+6 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/crypto/buffer.ts` (+6 -6) </details> ### 📄 Description An early return value will still lead to a timing attack issue Related: https://github.com/better-auth/utils/pull/12 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 12:12:54 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#5172
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?