github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #5172] [MERGED] docs: complete incomplete sentence about cookie prefixes #31424

New Issue
Closed
opened 2026-04-17 22:17:43 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-17 22:17:43 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/5172
Author: @ahmed-abdat
Created: 10/8/2025
Status: ✅ Merged
Merged: 10/11/2025
Merged by: @Bekacru

Base: canary ← Head: docs/fix-incomplete-cookie-prefix-sentence

📝 Commits (2)

  • c4b2d94 docs: complete incomplete sentence about cookie prefixes in plugins documentation
  • d29d590 Apply suggestion from @Copilot

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 docs/content/docs/concepts/plugins.mdx (+1 -1)

📄 Description

Description

Fixes the incomplete sentence in the plugins documentation about createAuthCookie function.

Changes

  • Completed the sentence explaining that __Secure- prefix is applied based on whether the connection is secure (HTTPS) or the application is running in production mode
  • Removed mention of __Host- prefix as it's not currently implemented in the codebase (verified in packages/better-auth/src/cookies/index.ts)

Issue

Closes #4908

Testing

  • Verified the sentence now provides clear information about cookie prefix behavior
  • Cross-referenced with actual implementation in cookies/index.ts (line 24) to ensure accuracy

Summary by cubic

Fixes the incomplete sentence in the plugins docs for createAuthCookie. Clarifies that the __Secure- prefix is applied on HTTPS or in production and removes the __Host- mention since it’s not implemented; closes #4908.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/5172 **Author:** [@ahmed-abdat](https://github.com/ahmed-abdat) **Created:** 10/8/2025 **Status:** ✅ Merged **Merged:** 10/11/2025 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `canary` ← **Head:** `docs/fix-incomplete-cookie-prefix-sentence` --- ### 📝 Commits (2) - [`c4b2d94`](https://github.com/better-auth/better-auth/commit/c4b2d94ea62e54b2d689aa95bdfc75d86fce448f) docs: complete incomplete sentence about cookie prefixes in plugins documentation - [`d29d590`](https://github.com/better-auth/better-auth/commit/d29d59011fff8741ce9799990f91e31b61dcca60) Apply suggestion from @Copilot ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `docs/content/docs/concepts/plugins.mdx` (+1 -1) </details> ### 📄 Description ## Description Fixes the incomplete sentence in the plugins documentation about `createAuthCookie` function. ## Changes - Completed the sentence explaining that `__Secure-` prefix is applied based on whether the connection is secure (HTTPS) or the application is running in production mode - Removed mention of `__Host-` prefix as it's not currently implemented in the codebase (verified in `packages/better-auth/src/cookies/index.ts`) ## Issue Closes #4908 ## Testing - Verified the sentence now provides clear information about cookie prefix behavior - Cross-referenced with actual implementation in `cookies/index.ts` (line 24) to ensure accuracy <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Fixes the incomplete sentence in the plugins docs for createAuthCookie. Clarifies that the __Secure- prefix is applied on HTTPS or in production and removes the __Host- mention since it’s not implemented; closes #4908. <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-17 22:17:43 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#31424
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?