github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #3816] [MERGED] feat: allow getUserInfo returns number type #5023

New Issue
Closed
opened 2026-03-13 12:08:14 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 12:08:14 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/3816
Author: @himself65
Created: 8/6/2025
Status: ✅ Merged
Merged: 8/6/2025
Merged by: @Bekacru

Base: canary ← Head: himself65/2025/08/05/user-info

📝 Commits (6)

  • acb8966 fix: check user info id before link account
  • 000ef84 fix: don't check
  • 3a27be9 feat: allow getUserInfo returns number type
  • c55020d feat: allow getUserInfo returns number type
  • 760aa26 fix: revert
  • 459dbeb fix: lint

📊 Changes

8 files changed (+26 additions, -24 deletions)

View changed files

📝 packages/better-auth/src/api/routes/account.ts (+4 -4)
📝 packages/better-auth/src/api/routes/callback.ts (+4 -3)
📝 packages/better-auth/src/api/routes/sign-in.ts (+2 -2)
📝 packages/better-auth/src/db/internal-adapter.ts (+10 -10)
📝 packages/better-auth/src/oauth2/types.ts (+1 -1)
📝 packages/better-auth/src/plugins/magic-link/magic-link.test.ts (+3 -2)
📝 packages/better-auth/src/social-providers/github.ts (+1 -1)
📝 packages/better-auth/src/social-providers/gitlab.ts (+1 -1)

📄 Description

Similar to https://github.com/better-auth/better-auth/pull/3815

Fixes: https://github.com/better-auth/better-auth/issues/3814, https://github.com/better-auth/better-auth/issues/2062

But now we allow a number as userInfo.id, since some provider does that. We do type convert internally, and this would make code more robust

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/3816 **Author:** [@himself65](https://github.com/himself65) **Created:** 8/6/2025 **Status:** ✅ Merged **Merged:** 8/6/2025 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `canary` ← **Head:** `himself65/2025/08/05/user-info` --- ### 📝 Commits (6) - [`acb8966`](https://github.com/better-auth/better-auth/commit/acb89668047bc44f66db6a10ea9d76a28ac228bd) fix: check user info id before link account - [`000ef84`](https://github.com/better-auth/better-auth/commit/000ef84d6f63e472d533976e764ca4ba9680525a) fix: don't check - [`3a27be9`](https://github.com/better-auth/better-auth/commit/3a27be9fd2bc89b188cde661b41ba861d8ddc9c6) feat: allow `getUserInfo` returns number type - [`c55020d`](https://github.com/better-auth/better-auth/commit/c55020d79d44b227d8450bae1786b3eb07f31f78) feat: allow `getUserInfo` returns number type - [`760aa26`](https://github.com/better-auth/better-auth/commit/760aa26f205a2edc58b0cfba8fa807642e24198a) fix: revert - [`459dbeb`](https://github.com/better-auth/better-auth/commit/459dbeb295a8568b63b557a41245e633958c176c) fix: lint ### 📊 Changes **8 files changed** (+26 additions, -24 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/api/routes/account.ts` (+4 -4) 📝 `packages/better-auth/src/api/routes/callback.ts` (+4 -3) 📝 `packages/better-auth/src/api/routes/sign-in.ts` (+2 -2) 📝 `packages/better-auth/src/db/internal-adapter.ts` (+10 -10) 📝 `packages/better-auth/src/oauth2/types.ts` (+1 -1) 📝 `packages/better-auth/src/plugins/magic-link/magic-link.test.ts` (+3 -2) 📝 `packages/better-auth/src/social-providers/github.ts` (+1 -1) 📝 `packages/better-auth/src/social-providers/gitlab.ts` (+1 -1) </details> ### 📄 Description Similar to https://github.com/better-auth/better-auth/pull/3815 Fixes: https://github.com/better-auth/better-auth/issues/3814, https://github.com/better-auth/better-auth/issues/2062 But now we allow a number as `userInfo.id`, since some provider does that. We do type convert internally, and this would make code more robust --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 12:08:14 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#5023
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?