github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #1455] [MERGED] Astro example: Add missing imports, remove unused scripts, fix indentation #3816

New Issue
Closed
opened 2026-03-13 11:14:55 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 11:14:55 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/1455
Author: @theinfinit
Created: 2/15/2025
Status: ✅ Merged
Merged: 2/16/2025
Merged by: @Bekacru

Base: main ← Head: fix/astro-example-imports

📝 Commits (1)

  • 0fede60 Astro example: Add missing imports, remove unused scripts, fix indentation

📊 Changes

9 files changed (+85 additions, -79 deletions)

View changed files

📝 examples/astro-example/package.json (+1 -3)
📝 examples/astro-example/src/auth.ts (+2 -1)
📝 examples/astro-example/src/layouts/root-layout.astro (+23 -22)
📝 examples/astro-example/src/pages/dashboard.astro (+3 -1)
📝 examples/astro-example/src/pages/index.astro (+41 -41)
📝 examples/astro-example/src/pages/sign-in.astro (+4 -2)
📝 examples/astro-example/src/pages/sign-up.astro (+4 -3)
📝 examples/astro-example/src/pages/two-factor.astro (+3 -2)
📝 examples/astro-example/src/pages/two-factor/email.astro (+4 -4)

📄 Description

  • package.json
    • "start" script doesn't even execute all the commands we need to start working dev server
    • "astro" script is redundant with pnpm
  • Missing imports
    • Example doesn't work without imports
    • I'm not aware of any auto-import features in Astro
    • VS Code is complaining about missing imports too
  • Fixed messed up indentation along the way
  • Moved <script> tag outside the <RootLayout> component as per Astro convention

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/1455 **Author:** [@theinfinit](https://github.com/theinfinit) **Created:** 2/15/2025 **Status:** ✅ Merged **Merged:** 2/16/2025 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `main` ← **Head:** `fix/astro-example-imports` --- ### 📝 Commits (1) - [`0fede60`](https://github.com/better-auth/better-auth/commit/0fede60c86bee576404824babeb9d9161a063f51) Astro example: Add missing imports, remove unused scripts, fix indentation ### 📊 Changes **9 files changed** (+85 additions, -79 deletions) <details> <summary>View changed files</summary> 📝 `examples/astro-example/package.json` (+1 -3) 📝 `examples/astro-example/src/auth.ts` (+2 -1) 📝 `examples/astro-example/src/layouts/root-layout.astro` (+23 -22) 📝 `examples/astro-example/src/pages/dashboard.astro` (+3 -1) 📝 `examples/astro-example/src/pages/index.astro` (+41 -41) 📝 `examples/astro-example/src/pages/sign-in.astro` (+4 -2) 📝 `examples/astro-example/src/pages/sign-up.astro` (+4 -3) 📝 `examples/astro-example/src/pages/two-factor.astro` (+3 -2) 📝 `examples/astro-example/src/pages/two-factor/email.astro` (+4 -4) </details> ### 📄 Description - package.json - "start" script doesn't even execute all the commands we need to start working dev server - "astro" script is redundant with pnpm - Missing imports - Example doesn't work without imports - I'm not aware of any auto-import features in Astro - VS Code is complaining about missing imports too - Fixed messed up indentation along the way - Moved `<script>` tag outside the `<RootLayout>` component as per Astro convention --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 11:14:55 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#3816
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?