github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-26 17:06:41 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

fix(one-tap): respect user dismiss actions in prompt retry logic (#7211)

Browse Source
This commit is contained in:
Taesu
2026-01-09 11:41:11 +09:00
committed by GitHub
parent 6ac030c3c5
commit ca9dfd78e6
1 changed files with 19 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
packages/better-auth/src/plugins/one-tap/client.ts
View File

@@ -105,6 +105,15 @@ function isFedCMSupported() {
return typeof window !== "undefined" && "IdentityCredential" in window;
}
/**
* Reasons that should NOT trigger a retry.
* @see https://developers.google.com/identity/gsi/web/reference/js-reference
*/
const noRetryReasons = {
dismissed: ["credential_returned", "cancel_called"],
skipped: ["user_cancel", "tap_outside"],
} as const;
export const oneTapClient = (options: GoogleOneTapOptions) => {
return {
id: "one-tap",
@@ -241,6 +250,11 @@ export const oneTapClient = (options: GoogleOneTapOptions) => {
notification.isDismissedMoment &&
notification.isDismissedMoment()
) {
const reason = notification.getDismissedReason?.();
if (noRetryReasons.dismissed.includes(reason)) {
opts?.onPromptNotification?.(notification);
return;
}
if (attempt < maxAttempts) {
const delay = Math.pow(2, attempt) * baseDelay;
setTimeout(() => handlePrompt(attempt + 1), delay);
@@ -251,6 +265,11 @@ export const oneTapClient = (options: GoogleOneTapOptions) => {
notification.isSkippedMoment &&
notification.isSkippedMoment()
) {
const reason = notification.getSkippedReason?.();
if (noRetryReasons.skipped.includes(reason)) {
opts?.onPromptNotification?.(notification);
return;
}
if (attempt < maxAttempts) {
const delay = Math.pow(2, attempt) * baseDelay;
setTimeout(() => handlePrompt(attempt + 1), delay);