github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-21 06:57:52 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #4386] [MERGED] [PM-15087] Update the device push token every 7 days #98294

New Issue
Closed
opened 2026-05-31 00:24:19 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-31 00:24:19 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4386
Author: @mzieniukbw
Created: 11/26/2024
Status: ✅ Merged
Merged: 6/20/2025
Merged by: @mzieniukbw

Base: main ← Head: km/pm-15087

📝 Commits (7)

  • 7a6b9a7 PM-15087: Update the device push token every 7 days
  • 6e91c43 PM-15087: Fix unit tests
  • 6b581ea PM-15087: Fix linting
  • 0ed7521 Merge branch 'main' into km/pm-15087
  • eda5374 PM-15087: Fix PushManager unit test
  • e4c7d3b Merge branch 'main' into km/pm-15087
  • ac6b52c Merge branch 'main' into km/pm-15087

📊 Changes

2 files changed (+87 additions, -40 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/PushManagerImpl.kt (+12 -13)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/platform/manager/PushManagerTest.kt (+75 -27)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-15087

📔 Objective

Update the device push token every 7 days.

For the device to receive relevant push notifications, the device needs to be registered with correct Azure Notification Hub tags. If they change, we need to perform migration for all devices. With this change, manual migrations are no longer necessary, since devices updates the token against the Bitwarden server periodically, updating the tags with Azure Notification Hub.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4386 **Author:** [@mzieniukbw](https://github.com/mzieniukbw) **Created:** 11/26/2024 **Status:** ✅ Merged **Merged:** 6/20/2025 **Merged by:** [@mzieniukbw](https://github.com/mzieniukbw) **Base:** `main` ← **Head:** `km/pm-15087` --- ### 📝 Commits (7) - [`7a6b9a7`](https://github.com/bitwarden/android/commit/7a6b9a7633dfe0fd7e96b56a83efc780d1b001e2) PM-15087: Update the device push token every 7 days - [`6e91c43`](https://github.com/bitwarden/android/commit/6e91c432ab8ec90d55e066ce029d79b645200bc2) PM-15087: Fix unit tests - [`6b581ea`](https://github.com/bitwarden/android/commit/6b581ea29ee49c2c5ca0766050d36610a18ef312) PM-15087: Fix linting - [`0ed7521`](https://github.com/bitwarden/android/commit/0ed7521963b9a00bbf45665a3d0b3dc4f32d169d) Merge branch 'main' into km/pm-15087 - [`eda5374`](https://github.com/bitwarden/android/commit/eda53742709042ccdbd3eee22fb0ff4dd17e291a) PM-15087: Fix PushManager unit test - [`e4c7d3b`](https://github.com/bitwarden/android/commit/e4c7d3b5ed3a75718c6b90690c3136b10e94b613) Merge branch 'main' into km/pm-15087 - [`ac6b52c`](https://github.com/bitwarden/android/commit/ac6b52c9e222610b77ad619e47b0370aec501f04) Merge branch 'main' into km/pm-15087 ### 📊 Changes **2 files changed** (+87 additions, -40 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/PushManagerImpl.kt` (+12 -13) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/platform/manager/PushManagerTest.kt` (+75 -27) </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-15087 ## 📔 Objective Update the device push token every 7 days. For the device to receive relevant push notifications, the device needs to be registered with correct Azure Notification Hub tags. If they change, we need to perform migration for all devices. With this change, manual migrations are no longer necessary, since devices updates the token against the Bitwarden server periodically, updating the tags with Azure Notification Hub. ## 📸 Screenshots <!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. --> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-31 00:24:19 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#98294