[PR #3738] [MERGED] Add logging for SDK functionality in debug only #4386

New Issue

2025-11-26T23:43:46-06:00

GiteaMirror commented

2025-11-26 23:43:46 -06:00

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3738
Author: @david-livefront
Created: 8/14/2024
Status: ✅ Merged
Merged: 8/14/2024
Merged by: @david-livefront

Base: main ← Head: sdk-debug-logging

📝 Commits (1)

27c10c2 Add logging for SDK functionality in debug only

📊 Changes

4 files changed (+98 additions, -72 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/data/auth/datasource/sdk/AuthSdkSourceImpl.kt (+11 -14)
➕ app/src/main/java/com/x8bit/bitwarden/data/platform/datasource/sdk/BaseSdkSource.kt (+35 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/tools/generator/datasource/sdk/GeneratorSdkSourceImpl.kt (+10 -13)
📝 app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/sdk/VaultSdkSourceImpl.kt (+42 -45)

📄 Description

🎟️ Tracking

N/A

📔 Objective

This PR adds logging to debug build for failing SDK interactions. The goal is to help us track bug when interacting with the SDK better.

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3738 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 8/14/2024 **Status:** ✅ Merged **Merged:** 8/14/2024 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `sdk-debug-logging` --- ### 📝 Commits (1) - [`27c10c2`](https://github.com/bitwarden/android/commit/27c10c25db1ffda701a75bec2cc775922d919ae9) Add logging for SDK functionality in debug only ### 📊 Changes **4 files changed** (+98 additions, -72 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/data/auth/datasource/sdk/AuthSdkSourceImpl.kt` (+11 -14) ➕ `app/src/main/java/com/x8bit/bitwarden/data/platform/datasource/sdk/BaseSdkSource.kt` (+35 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/tools/generator/datasource/sdk/GeneratorSdkSourceImpl.kt` (+10 -13) 📝 `app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/sdk/VaultSdkSourceImpl.kt` (+42 -45) </details> ### 📄 Description ## 🎟️ Tracking N/A ## 📔 Objective This PR adds logging to debug build for failing SDK interactions. The goal is to help us track bug when interacting with the SDK better. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines  - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-26 23:43:46 -06:00

GiteaMirror closed this issue