github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-08 04:16:40 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #2533] [CLOSED] [BEEEP][PM-2149] Improve Attachments UI/UX #9763

New Issue
Closed
opened 2026-04-11 02:28:45 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-11 02:28:45 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2533
Author: @fedemkr
Created: 5/22/2023
Status: ❌ Closed

Base: main ← Head: PM-2149-improve-attachment-uiux

📝 Commits (10+)

  • de41845 Bumped version to 2022.8.1 (#2039)
  • 8b11840 Add workaround for broken windows 2022 runner (#2040)
  • 5f7a1e7 Changed the right margin of the switch at Create Account(#2021)
  • 3d9555d [PS-1009] Changed keyboard on Passphrase generator to not allow emojis (#2038)
  • e829279 [SG-416] Updates to Bitwarden Authenticator (Feature Branch) (#2041)
  • 525288d Autosync the updated translations (#2042)
  • ecd4da0 [SG-598] Removed space from copied totp code (#2046)
  • 9163b9e [SG-599] Cannot read authenticator key if you don't include URI before TOTP Secret. (#2047)
  • d204e81 EC-487 Added helper to localize enum values and also a converter to use in xaml (#2048)
  • cdd9a5f Autosync the updated translations (#2050)

📊 Changes

7 files changed (+74 additions, -27 deletions)

View changed files

📝 src/Android/Services/DeviceActionService.cs (+10 -4)
📝 src/App/Abstractions/IDeviceActionService.cs (+3 -2)
📝 src/App/Pages/Vault/AttachmentsPageViewModel.cs (+13 -2)
📝 src/App/Resources/AppResources.Designer.cs (+27 -18)
📝 src/App/Resources/AppResources.resx (+3 -0)
📝 src/Core/Services/ApiService.cs (+8 -0)
📝 src/iOS.Core/Services/DeviceActionService.cs (+10 -1)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Improve attachments UI/UX adding the ability to cancel the upload of the file.

Code changes

  • Most files: Added the ability to have a CancellationToken being passed so the call can be cancelled.

Screenshots

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2533 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 5/22/2023 **Status:** ❌ Closed **Base:** `main` ← **Head:** `PM-2149-improve-attachment-uiux` --- ### 📝 Commits (10+) - [`de41845`](https://github.com/bitwarden/android/commit/de41845e3e7d7b0020ef57e2d0310c5068d3956a) Bumped version to 2022.8.1 (#2039) - [`8b11840`](https://github.com/bitwarden/android/commit/8b118408fa89e972caa0290041638052f9decd8e) Add workaround for broken windows 2022 runner (#2040) - [`5f7a1e7`](https://github.com/bitwarden/android/commit/5f7a1e769ab759cecb6b09db49ac07bd1ce58f03) Changed the right margin of the switch at Create Account(#2021) - [`3d9555d`](https://github.com/bitwarden/android/commit/3d9555d4208571ec063cd934fbb9014c252ff6d5) [PS-1009] Changed keyboard on Passphrase generator to not allow emojis (#2038) - [`e829279`](https://github.com/bitwarden/android/commit/e829279e29cf611ac6b1f400d29e9a5085ecb5d5) [SG-416] Updates to Bitwarden Authenticator (Feature Branch) (#2041) - [`525288d`](https://github.com/bitwarden/android/commit/525288d8046dd8792b67f89045d8cf5bccb16b10) Autosync the updated translations (#2042) - [`ecd4da0`](https://github.com/bitwarden/android/commit/ecd4da08ee068eaa1a0444db12500db5d6a82d3f) [SG-598] Removed space from copied totp code (#2046) - [`9163b9e`](https://github.com/bitwarden/android/commit/9163b9e4def2166ca8bd2a3f5f7cd56f137ecbf7) [SG-599] Cannot read authenticator key if you don't include URI before TOTP Secret. (#2047) - [`d204e81`](https://github.com/bitwarden/android/commit/d204e812e1c0487e378131383acf910bb6f1bdda) EC-487 Added helper to localize enum values and also a converter to use in xaml (#2048) - [`cdd9a5f`](https://github.com/bitwarden/android/commit/cdd9a5ff4db8a1ec2595cce7c1f75198a3f04da9) Autosync the updated translations (#2050) ### 📊 Changes **7 files changed** (+74 additions, -27 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Services/DeviceActionService.cs` (+10 -4) 📝 `src/App/Abstractions/IDeviceActionService.cs` (+3 -2) 📝 `src/App/Pages/Vault/AttachmentsPageViewModel.cs` (+13 -2) 📝 `src/App/Resources/AppResources.Designer.cs` (+27 -18) 📝 `src/App/Resources/AppResources.resx` (+3 -0) 📝 `src/Core/Services/ApiService.cs` (+8 -0) 📝 `src/iOS.Core/Services/DeviceActionService.cs` (+10 -1) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [X] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Improve attachments UI/UX adding the ability to cancel the upload of the file. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **Most files:** Added the ability to have a `CancellationToken` being passed so the call can be cancelled. ## Screenshots <!--Required for any UI changes. Delete if not applicable--> ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-11 02:28:45 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#9763
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?