github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-06-09 16:21:19 -05:00
Code Issues 2.2k Packages Projects Releases 127 Wiki Activity

[PR #3018] [MERGED] DEVOPS-1746 - Update iOS distribution certificate and profiles #83801

New Issue
Closed
opened 2026-05-22 18:09:35 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-22 18:09:35 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3018
Author: @vgrassia
Created: 2/21/2024
Status: ✅ Merged
Merged: 2/28/2024
Merged by: @vgrassia

Base: main ← Head: update-certs

📝 Commits (10+)

  • 615c472 Update build workflow
  • dd43997 Testing new logic for certificate in Key Vault
  • 4c26ac3 Remove provisioning profiles
  • fee1fff Add command for downloading provisioning profiles
  • 71612e3 Fix for loop
  • 041e09d Fix WatchOS provisioning profile filename
  • af85455 Remove secrets folder
  • 842e248 Update release workflow to remove secrets directory
  • a3e0350 Fix spelling on flag
  • a3a3d0e Add Azure login steps

📊 Changes

17 files changed (+95 additions, -136 deletions)

View changed files

➖ .github/secrets/GoogleService-Info.plist.gpg (+0 -0)
➖ .github/secrets/app_fdroid-keystore.jks.gpg (+0 -0)
➖ .github/secrets/app_play-keystore.jks.gpg (+0 -0)
➖ .github/secrets/app_upload-keystore.jks.gpg (+0 -0)
➖ .github/secrets/bitwarden-mobile-key.p12.gpg (+0 -0)
➖ .github/secrets/dist_autofill.mobileprovision.gpg (+0 -0)
➖ .github/secrets/dist_bitwarden.mobileprovision.gpg (+0 -0)
➖ .github/secrets/dist_extension.mobileprovision.gpg (+0 -0)
➖ .github/secrets/dist_share_extension.mobileprovision.gpg (+0 -0)
➖ .github/secrets/dist_watch_app.mobileprovision.gpg (+0 -0)
➖ .github/secrets/dist_watch_app_extension.mobileprovision.gpg (+0 -0)
➖ .github/secrets/google-services.json.gpg (+0 -3)
➖ .github/secrets/iphone-distribution-cert.p12.gpg (+0 -0)
➖ .github/secrets/play_creds.json.gpg (+0 -0)
➖ .github/secrets/store_fdroid-keystore.jks.gpg (+0 -0)
📝 .github/workflows/build.yml (+89 -128)
📝 .github/workflows/release.yml (+6 -5)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

This PR updates the iOS distribution certificate and all of the provisioning profiles. I have also included moving all of the files from .github/secrets to an Azure Storage Account named bitwardenci.

Successful run here.

Code changes

  • .github/workflows/build.yml: Formatting. Changed jks and mobileprovision files to download from Storage Account. Download certificate from Key Vault. Remove extra echo and Write-Output to shorten file. Change any ~ to $HOME for consistency. Move some inline bash variables to env key.
  • .github/workflows/release.yml: Formatting. Download files from Storage Account.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3018 **Author:** [@vgrassia](https://github.com/vgrassia) **Created:** 2/21/2024 **Status:** ✅ Merged **Merged:** 2/28/2024 **Merged by:** [@vgrassia](https://github.com/vgrassia) **Base:** `main` ← **Head:** `update-certs` --- ### 📝 Commits (10+) - [`615c472`](https://github.com/bitwarden/android/commit/615c472236a74c0dd6bf6823e68aabeed1de215f) Update build workflow - [`dd43997`](https://github.com/bitwarden/android/commit/dd439974565ea480adc5c76f961995c10160e6ea) Testing new logic for certificate in Key Vault - [`4c26ac3`](https://github.com/bitwarden/android/commit/4c26ac377256e103c6f92f73daa2a4aec8b2d9e9) Remove provisioning profiles - [`fee1fff`](https://github.com/bitwarden/android/commit/fee1fff272f52c5e79b6d6fb69e6208ac335a5c7) Add command for downloading provisioning profiles - [`71612e3`](https://github.com/bitwarden/android/commit/71612e3b676c8315a29c9c8ac0edaec0ff780229) Fix for loop - [`041e09d`](https://github.com/bitwarden/android/commit/041e09d08593b691355a793c1897dad127694bfd) Fix WatchOS provisioning profile filename - [`af85455`](https://github.com/bitwarden/android/commit/af854555a7541967cd6758354bcf706eced4b948) Remove secrets folder - [`842e248`](https://github.com/bitwarden/android/commit/842e248c337b3f3ae97b0d724402c6eaf7ad5423) Update release workflow to remove secrets directory - [`a3e0350`](https://github.com/bitwarden/android/commit/a3e03503d090b55003d7a1ff19ae7f73e4bba30a) Fix spelling on flag - [`a3a3d0e`](https://github.com/bitwarden/android/commit/a3a3d0ea9af85da271249e88cce6d95c4564d13c) Add Azure login steps ### 📊 Changes **17 files changed** (+95 additions, -136 deletions) <details> <summary>View changed files</summary> ➖ `.github/secrets/GoogleService-Info.plist.gpg` (+0 -0) ➖ `.github/secrets/app_fdroid-keystore.jks.gpg` (+0 -0) ➖ `.github/secrets/app_play-keystore.jks.gpg` (+0 -0) ➖ `.github/secrets/app_upload-keystore.jks.gpg` (+0 -0) ➖ `.github/secrets/bitwarden-mobile-key.p12.gpg` (+0 -0) ➖ `.github/secrets/dist_autofill.mobileprovision.gpg` (+0 -0) ➖ `.github/secrets/dist_bitwarden.mobileprovision.gpg` (+0 -0) ➖ `.github/secrets/dist_extension.mobileprovision.gpg` (+0 -0) ➖ `.github/secrets/dist_share_extension.mobileprovision.gpg` (+0 -0) ➖ `.github/secrets/dist_watch_app.mobileprovision.gpg` (+0 -0) ➖ `.github/secrets/dist_watch_app_extension.mobileprovision.gpg` (+0 -0) ➖ `.github/secrets/google-services.json.gpg` (+0 -3) ➖ `.github/secrets/iphone-distribution-cert.p12.gpg` (+0 -0) ➖ `.github/secrets/play_creds.json.gpg` (+0 -0) ➖ `.github/secrets/store_fdroid-keystore.jks.gpg` (+0 -0) 📝 `.github/workflows/build.yml` (+89 -128) 📝 `.github/workflows/release.yml` (+6 -5) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [X] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> This PR updates the iOS distribution certificate and all of the provisioning profiles. I have also included moving all of the files from `.github/secrets` to an Azure Storage Account named `bitwardenci`. Successful run [here](https://github.com/bitwarden/mobile/actions/runs/7995082617). ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **.github/workflows/build.yml:** Formatting. Changed `jks` and `mobileprovision` files to download from Storage Account. Download certificate from Key Vault. Remove extra `echo` and `Write-Output` to shorten file. Change any `~` to `$HOME` for consistency. Move some inline bash variables to `env` key. * **.github/workflows/release.yml:** Formatting. Download files from Storage Account. ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-22 18:09:35 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#83801
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?