github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-06-09 16:21:19 -05:00
Code Issues 2.2k Packages Projects Releases 127 Wiki Activity

[PR #1633] [MERGED] [KeyConnector] Add support for key connector OTP #3018

New Issue
Closed
opened 2025-11-26 23:27:12 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:27:12 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1633
Author: @jlf0dev
Created: 11/5/2021
Status: ✅ Merged
Merged: 11/11/2021
Merged by: @jlf0dev

Base: master ← Head: feature/key-connector

📝 Commits (10+)

  • d3585df initial commit
  • fd2496f finish auth workflow for key connector sso login
  • 8d5d019 Bypass lock page if already unlocked
  • 4a37048 Move logic to KeyConnectorService, log out if no pin or biometric is set
  • 99dd8c5 Disable password reprompt when using key connector
  • 0fa716a hide password reprompt checkbox when editing or adding cipher
  • 1b59749 add PostUserKey and PostSetKeyConnector calls
  • 0003614 add ConvertMasterPasswordPage
  • a156e5a add functionality to RemoveMasterPasswordPage
  • 9420c9a Hide Change Master Password button if using key connector

📊 Changes

40 files changed (+866 additions, -69 deletions)

View changed files

📝 src/App/Abstractions/IPasswordRepromptService.cs (+2 -0)
📝 src/App/App.xaml.cs (+9 -0)
📝 src/App/Pages/Accounts/LockPage.xaml.cs (+1 -2)
📝 src/App/Pages/Accounts/LockPageViewModel.cs (+8 -0)
📝 src/App/Pages/Accounts/LoginSsoPage.xaml.cs (+8 -1)
➕ src/App/Pages/Accounts/RemoveMasterPasswordPage.xaml (+33 -0)
➕ src/App/Pages/Accounts/RemoveMasterPasswordPage.xaml.cs (+58 -0)
➕ src/App/Pages/Accounts/RemoveMasterPasswordPageViewModel.cs (+56 -0)
📝 src/App/Pages/Settings/ExportVaultPage.xaml (+27 -15)
📝 src/App/Pages/Settings/ExportVaultPage.xaml.cs (+12 -3)
📝 src/App/Pages/Settings/ExportVaultPageViewModel.cs (+58 -22)
📝 src/App/Pages/Settings/SettingsPage/SettingsPageViewModel.cs (+8 -1)
📝 src/App/Pages/TabsPage.cs (+11 -0)
📝 src/App/Pages/Vault/AddEditPage.xaml (+1 -1)
📝 src/App/Pages/Vault/AddEditPage.xaml.cs (+5 -0)
📝 src/App/Resources/AppResources.Designer.cs (+51 -1)
📝 src/App/Resources/AppResources.resx (+24 -0)
📝 src/App/Services/MobilePasswordRepromptService.cs (+12 -0)
📝 src/Core/Abstractions/IApiService.cs (+7 -0)
➕ src/Core/Abstractions/IKeyConnectorService.cs (+16 -0)

...and 20 more files

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Add support for Key Connector in mobile

Code changes

Please refer to bitwarden/jslib#527 and bitwarden/web#1256 for similar implementations.

Screenshots

Testing requirements

  • Server backwards compatibility needs testing (older version of server). Mainly logging in with both MP and SSO.

Before you submit

  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1633 **Author:** [@jlf0dev](https://github.com/jlf0dev) **Created:** 11/5/2021 **Status:** ✅ Merged **Merged:** 11/11/2021 **Merged by:** [@jlf0dev](https://github.com/jlf0dev) **Base:** `master` ← **Head:** `feature/key-connector` --- ### 📝 Commits (10+) - [`d3585df`](https://github.com/bitwarden/android/commit/d3585df63878eb798c3c05718a46bce624bd1af5) initial commit - [`fd2496f`](https://github.com/bitwarden/android/commit/fd2496f7119e6d8a19e5c796a1375889e4ab9286) finish auth workflow for key connector sso login - [`8d5d019`](https://github.com/bitwarden/android/commit/8d5d019d331ef281368da8f79352c6dd5fd94594) Bypass lock page if already unlocked - [`4a37048`](https://github.com/bitwarden/android/commit/4a37048265da98022ca2a77fcca28223b50a89e6) Move logic to KeyConnectorService, log out if no pin or biometric is set - [`99dd8c5`](https://github.com/bitwarden/android/commit/99dd8c580a2c99b089dbdf0826df4f24e22825a6) Disable password reprompt when using key connector - [`0fa716a`](https://github.com/bitwarden/android/commit/0fa716a2e39d961493a7cd7c55a1635d807e983a) hide password reprompt checkbox when editing or adding cipher - [`1b59749`](https://github.com/bitwarden/android/commit/1b597494843dbd5fc3162020aa3369d2c19beb09) add PostUserKey and PostSetKeyConnector calls - [`0003614`](https://github.com/bitwarden/android/commit/0003614eb5c05ce24468b0c69749503d79831d7b) add ConvertMasterPasswordPage - [`a156e5a`](https://github.com/bitwarden/android/commit/a156e5a87f120703f928f8ea4a7db67024be8877) add functionality to RemoveMasterPasswordPage - [`9420c9a`](https://github.com/bitwarden/android/commit/9420c9a13160a0d45f9398d8ae169c96c909532f) Hide Change Master Password button if using key connector ### 📊 Changes **40 files changed** (+866 additions, -69 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Abstractions/IPasswordRepromptService.cs` (+2 -0) 📝 `src/App/App.xaml.cs` (+9 -0) 📝 `src/App/Pages/Accounts/LockPage.xaml.cs` (+1 -2) 📝 `src/App/Pages/Accounts/LockPageViewModel.cs` (+8 -0) 📝 `src/App/Pages/Accounts/LoginSsoPage.xaml.cs` (+8 -1) ➕ `src/App/Pages/Accounts/RemoveMasterPasswordPage.xaml` (+33 -0) ➕ `src/App/Pages/Accounts/RemoveMasterPasswordPage.xaml.cs` (+58 -0) ➕ `src/App/Pages/Accounts/RemoveMasterPasswordPageViewModel.cs` (+56 -0) 📝 `src/App/Pages/Settings/ExportVaultPage.xaml` (+27 -15) 📝 `src/App/Pages/Settings/ExportVaultPage.xaml.cs` (+12 -3) 📝 `src/App/Pages/Settings/ExportVaultPageViewModel.cs` (+58 -22) 📝 `src/App/Pages/Settings/SettingsPage/SettingsPageViewModel.cs` (+8 -1) 📝 `src/App/Pages/TabsPage.cs` (+11 -0) 📝 `src/App/Pages/Vault/AddEditPage.xaml` (+1 -1) 📝 `src/App/Pages/Vault/AddEditPage.xaml.cs` (+5 -0) 📝 `src/App/Resources/AppResources.Designer.cs` (+51 -1) 📝 `src/App/Resources/AppResources.resx` (+24 -0) 📝 `src/App/Services/MobilePasswordRepromptService.cs` (+12 -0) 📝 `src/Core/Abstractions/IApiService.cs` (+7 -0) ➕ `src/Core/Abstractions/IKeyConnectorService.cs` (+16 -0) _...and 20 more files_ </details> ### 📄 Description ## Type of change - [ ] Bug fix - [x] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Add support for Key Connector in mobile ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> Please refer to bitwarden/jslib#527 and bitwarden/web#1256 for similar implementations. ## Screenshots <!--Required for any UI changes. Delete if not applicable--> ## Testing requirements <!--What functionality requires testing by QA? This includes testing new behavior and regression testing--> - Server backwards compatibility needs testing (older version of server). Mainly logging in with both MP and SSO. ## Before you submit - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:27:12 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3018
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?