github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-09 03:33:36 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #6176] [PM-27290] Remove password unlock method #6379

New Issue
Open
opened 2025-11-27 00:22:58 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-27 00:22:58 -06:00
Owner
Copy Link

Original Pull Request: https://github.com/bitwarden/android/pull/6176

State: open
Merged: No

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-27290

📔 Objective

This pull request refactors authentication and vault unlocking logic to exclusively use the MasterPasswordUnlock method, removing support for the older Password method. This change simplifies the codebase, improves clarity, and prepares for future SDK updates. The test suite and utility extensions have also been updated to reflect this change.

Authentication and Vault Unlocking Logic

  • Refactored AuthRepositoryImpl and VaultRepositoryImpl to use InitUserCryptoMethod.MasterPasswordUnlock exclusively, removing all logic related to InitUserCryptoMethod.Password. This ensures that vault unlocking now requires master password unlock data and no longer relies on a separate user key.

  • Updated VaultLockManagerImpl to only handle the MasterPasswordUnlock method for password hashing and KDF updates, removing branches for the Password method.

Utility Extensions

  • Modified InitUserCryptoMethodExtensions.kt so that logTag no longer supports the Password method. It now throws an exception and logs an error if an unsupported method is encountered, anticipating future SDK changes.

Test Suite Updates

  • Updated all relevant tests in AuthRepositoryTest.kt to use MasterPasswordUnlock instead of Password, and replaced references to user keys with master password unlock test data. Also updated mock password hash values for consistency.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes
**Original Pull Request:** https://github.com/bitwarden/android/pull/6176 **State:** open **Merged:** No --- ## 🎟️ Tracking <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> https://bitwarden.atlassian.net/browse/PM-27290 ## 📔 Objective <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> This pull request refactors authentication and vault unlocking logic to exclusively use the `MasterPasswordUnlock` method, removing support for the older `Password` method. This change simplifies the codebase, improves clarity, and prepares for future SDK updates. The test suite and utility extensions have also been updated to reflect this change. ### Authentication and Vault Unlocking Logic * Refactored `AuthRepositoryImpl` and `VaultRepositoryImpl` to use `InitUserCryptoMethod.MasterPasswordUnlock` exclusively, removing all logic related to `InitUserCryptoMethod.Password`. This ensures that vault unlocking now requires master password unlock data and no longer relies on a separate user key. * Updated `VaultLockManagerImpl` to only handle the `MasterPasswordUnlock` method for password hashing and KDF updates, removing branches for the `Password` method. ### Utility Extensions * Modified `InitUserCryptoMethodExtensions.kt` so that `logTag` no longer supports the `Password` method. It now throws an exception and logs an error if an unsupported method is encountered, anticipating future SDK changes. ### Test Suite Updates * Updated all relevant tests in `AuthRepositoryTest.kt` to use `MasterPasswordUnlock` instead of `Password`, and replaced references to user keys with master password unlock test data. Also updated mock password hash values for consistency. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes
GiteaMirror added the pull-request label 2025-11-27 00:22:58 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#6379
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?