github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-22 12:32:53 -05:00
Code Issues 144 Packages Projects Releases 118 Wiki Activity

[PR #5946] [PM-26111] Implement Review Export Screen and Navigation #6176

New Issue
Closed
opened 2025-11-27 00:20:36 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-27 00:20:36 -06:00
Owner
Copy Link

Original Pull Request: https://github.com/bitwarden/android/pull/5946

State: closed
Merged: Yes

🎟️ Tracking

PM-26111

📔 Objective

This commit introduces the "Review Export" screen and its associated navigation logic within the export items flow.

This screen displays a snapshot of the types of credentials being exported, along with an expected count of each type. From here, the user can continue to Import credentials from Bitwarden or Cancel.

Key changes include:

  • Added ReviewExportScreen.kt to display a summary of items to be exported.
  • Added ReviewExportViewModel.kt to manage the state and logic for the review screen.
  • Added ReviewExportHandlers.kt to manage user interactions on the review screen.
  • Added ReviewExportNavigation.kt to define the navigation route and destination for the review screen.
  • Integrated the review export screen into the exportItemsGraph.
  • Added new string resources for the review export screen.
  • Added unit tests for ReviewExportScreen, ReviewExportViewModel.
  • Fixed a typo in LocalCredentialExchangeCompletionManagerProvider.kt.
  • Updated RootNavScreenTest.kt to use ExportItemsGraphRoute.

📸 Screenshots

Coming soon!

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes
**Original Pull Request:** https://github.com/bitwarden/android/pull/5946 **State:** closed **Merged:** Yes --- ## 🎟️ Tracking PM-26111 ## 📔 Objective This commit introduces the "Review Export" screen and its associated navigation logic within the export items flow. This screen displays a snapshot of the types of credentials being exported, along with an expected count of each type. From here, the user can continue to Import credentials from Bitwarden or Cancel. Key changes include: - Added `ReviewExportScreen.kt` to display a summary of items to be exported. - Added `ReviewExportViewModel.kt` to manage the state and logic for the review screen. - Added `ReviewExportHandlers.kt` to manage user interactions on the review screen. - Added `ReviewExportNavigation.kt` to define the navigation route and destination for the review screen. - Integrated the review export screen into the `exportItemsGraph`. - Added new string resources for the review export screen. - Added unit tests for `ReviewExportScreen`, `ReviewExportViewModel`. - Fixed a typo in `LocalCredentialExchangeCompletionManagerProvider.kt`. - Updated `RootNavScreenTest.kt` to use `ExportItemsGraphRoute`. ## 📸 Screenshots Coming soon! ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes
GiteaMirror added the pull-request label 2025-11-27 00:20:36 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#6176
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?