github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-22 12:32:53 -05:00
Code Issues 144 Packages Projects Releases 118 Wiki Activity

[PR #6129] [PM-27869] fix/[PM-26241] : draw out keyboard on talkback click #6341

New Issue
Closed
opened 2025-11-27 00:22:31 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-27 00:22:31 -06:00
Owner
Copy Link

Original Pull Request: https://github.com/bitwarden/android/pull/6129

State: closed
Merged: Yes

🎟️ Tracking

https://github.com/bitwarden/android/issues/5951

📔 Objective

  • Fixes Bug: PM-26241
  • The Problem: The on-screen keyboard failed to appear when TalkBack users selected a text field on the "edit item" screen.
  • The Solution: This PR ensures that the text field correctly requests and receives focus when activated via TalkBack, which properly triggers the keyboard to display.
  • Impact: Restores the ability for screen reader users to edit item details, ensuring the feature is accessible.

Test Updates

  • Context: The fix for the TalkBack focus behavior revealed that two unit tests were brittle. They were built on an incorrect assumption that text would always be inserted at the start of the field.

  • Solution: This PR also includes a commit to update these tests, making them more robust and aligning them with the new, correct cursor behavior.

📸 Screenshots

before.webm

after.webm

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes
**Original Pull Request:** https://github.com/bitwarden/android/pull/6129 **State:** closed **Merged:** Yes --- ## 🎟️ Tracking <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> https://github.com/bitwarden/android/issues/5951 ## 📔 Objective <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> * **Fixes Bug:** [PM-26241] * **The Problem:** The on-screen keyboard failed to appear when TalkBack users selected a text field on the "edit item" screen. * **The Solution:** This PR ensures that the text field correctly requests and receives focus when activated via TalkBack, which properly triggers the keyboard to display. * **Impact:** Restores the ability for screen reader users to edit item details, ensuring the feature is accessible. ### Test Updates * **Context:** The fix for the TalkBack focus behavior revealed that two unit tests were brittle. They were built on an incorrect assumption that text would always be inserted at the **start** of the field. * **Solution:** This PR also includes a commit to update these tests, making them more robust and aligning them with the new, correct cursor behavior. ## 📸 Screenshots <!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. --> [before.webm](https://github.com/user-attachments/assets/5ca3b6ba-4b4d-4285-9140-47b21c35ec30) [after.webm](https://github.com/user-attachments/assets/dd7fd4f0-32fa-4b2c-a54e-b399cf10f4c7) ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-26241]: https://bitwarden.atlassian.net/browse/PM-26241?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
GiteaMirror added the pull-request label 2025-11-27 00:22:31 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#6341
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?