github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-22 20:41:29 -05:00
Code Issues 144 Packages Projects Releases 118 Wiki Activity

[PR #6113] [PM-27657] KDF silent update with MasterPasswordUnlock data #6325

New Issue
Closed
opened 2025-11-27 00:22:22 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-27 00:22:22 -06:00
Owner
Copy Link

Original Pull Request: https://github.com/bitwarden/android/pull/6113

State: closed
Merged: Yes

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-27657

📔 Objective

This pull request updates the logic for updating KDF (Key Derivation Function) settings in the vault lock management code to support additional authentication methods, and ensures that the corresponding unit test is updated to reflect this change. The main focus is to allow KDF updates when unlocking with either the standard password or the master password unlock method.

Vault lock management improvements:

  • Updated VaultLockManagerImpl to support KDF updates for both InitUserCryptoMethod.Password and InitUserCryptoMethod.MasterPasswordUnlock by extracting the password from either method and passing it to kdfManager.updateKdfToMinimumsIfNeeded.

Testing improvements:

  • Updated the VaultLockManagerTest to explicitly call kdfManager.updateKdfToMinimumsIfNeeded with the master password unlock init method, ensuring the new logic is covered by tests.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes
**Original Pull Request:** https://github.com/bitwarden/android/pull/6113 **State:** closed **Merged:** Yes --- ## 🎟️ Tracking <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> https://bitwarden.atlassian.net/browse/PM-27657 ## 📔 Objective <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> This pull request updates the logic for updating KDF (Key Derivation Function) settings in the vault lock management code to support additional authentication methods, and ensures that the corresponding unit test is updated to reflect this change. The main focus is to allow KDF updates when unlocking with either the standard password or the master password unlock method. **Vault lock management improvements:** * Updated `VaultLockManagerImpl` to support KDF updates for both `InitUserCryptoMethod.Password` and `InitUserCryptoMethod.MasterPasswordUnlock` by extracting the password from either method and passing it to `kdfManager.updateKdfToMinimumsIfNeeded`. **Testing improvements:** * Updated the `VaultLockManagerTest` to explicitly call `kdfManager.updateKdfToMinimumsIfNeeded` with the master password unlock init method, ensuring the new logic is covered by tests. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes
GiteaMirror added the pull-request label 2025-11-27 00:22:22 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#6325
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?