[PR #5906] [PM-25824] Add "Import items" screen #6142

Closed
opened 2025-11-27 00:20:13 -06:00 by GiteaMirror · 0 comments
Owner

Original Pull Request: https://github.com/bitwarden/android/pull/5906

State: closed
Merged: Yes


🎟️ Tracking

PM-25824

📔 Objective

This commit introduces a new screen that allows users to import items from other credential managers using the Credential Manager Credential Exchange Framework.

The following changes are included:

  • Added ImportItemsScreen to allow users to select an app to import from or navigate to import from computer.
  • Added ImportItemsHandler to handle actions from the ImportItemsScreen.
  • Added new strings for the "Import items" feature.
  • Added new tests for the "Import items" feature.
  • Updated ImportItemsViewModel to handle the logic for the ImportItemsScreen.
  • Updated VaultRepository and CredentialExchangeImportManager to support importing items.
  • Updated LocalManagerProvider to include CredentialExchangeImporter.
  • Updated SnackbarRelay to include VAULT_SYNC_FAILED.
  • Updated CredentialExchangeImporterImpl to handle ImportCredentialsUnknownErrorException.

📸 Screenshots

image
**Original Pull Request:** https://github.com/bitwarden/android/pull/5906 **State:** closed **Merged:** Yes --- ## 🎟️ Tracking PM-25824 ## 📔 Objective This commit introduces a new screen that allows users to import items from other credential managers using the Credential Manager Credential Exchange Framework. The following changes are included: - Added `ImportItemsScreen` to allow users to select an app to import from or navigate to import from computer. - Added `ImportItemsHandler` to handle actions from the `ImportItemsScreen`. - Added new strings for the "Import items" feature. - Added new tests for the "Import items" feature. - Updated `ImportItemsViewModel` to handle the logic for the `ImportItemsScreen`. - Updated `VaultRepository` and `CredentialExchangeImportManager` to support importing items. - Updated `LocalManagerProvider` to include `CredentialExchangeImporter`. - Updated `SnackbarRelay` to include `VAULT_SYNC_FAILED`. - Updated `CredentialExchangeImporterImpl` to handle `ImportCredentialsUnknownErrorException`. ## 📸 Screenshots <img width="365" alt="image" src="https://github.com/user-attachments/assets/32983ef4-5164-47c2-918e-8660f6184241" /> <video width="356" src="https://github.com/user-attachments/assets/f581f072-e3a2-449b-8ee7-fc07b4521b18" /> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes
GiteaMirror added the pull-request label 2025-11-27 00:20:13 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#6142