github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-09 03:33:36 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #5605] [MERGED] PM-24240: Remove email verification feature flag #5906

New Issue
Closed
opened 2025-11-27 00:16:42 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-27 00:16:42 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/5605
Author: @david-livefront
Created: 7/28/2025
Status: ✅ Merged
Merged: 7/28/2025
Merged by: @david-livefront

Base: main ← Head: PM-24240-remove-email-verification-flag

📝 Commits (1)

  • f8054ca PM-24240: Remove email verification feature flag

📊 Changes

28 files changed (+36 additions, -2177 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/auth/AuthNavigation.kt (+0 -16)
➖ app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/createaccount/CreateAccountNavigation.kt (+0 -35)
➖ app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/createaccount/CreateAccountScreen.kt (+0 -329)
➖ app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/createaccount/CreateAccountViewModel.kt (+0 -595)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/landing/LandingNavigation.kt (+0 -2)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/landing/LandingScreen.kt (+0 -2)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/landing/LandingViewModel.kt (+1 -15)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/welcome/WelcomeNavigation.kt (+0 -2)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/welcome/WelcomeScreen.kt (+0 -2)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/welcome/WelcomeViewModel.kt (+2 -16)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/debugmenu/DebugMenuScreen.kt (+1 -1)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/debugmenu/components/FeatureFlagListItems.kt (+0 -2)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/platform/manager/FeatureFlagManagerTest.kt (+3 -3)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/platform/repository/DebugMenuRepositoryTest.kt (+3 -3)
➖ app/src/test/kotlin/com/x8bit/bitwarden/ui/auth/feature/createaccount/CreateAccountScreenTest.kt (+0 -319)
➖ app/src/test/kotlin/com/x8bit/bitwarden/ui/auth/feature/createaccount/CreateAccountTestUtil.kt (+0 -19)
➖ app/src/test/kotlin/com/x8bit/bitwarden/ui/auth/feature/createaccount/CreateAccountViewModelTest.kt (+0 -708)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/auth/feature/landing/LandingScreenTest.kt (+0 -8)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/auth/feature/landing/LandingViewModelTest.kt (+2 -22)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/auth/feature/welcome/WelcomeScreenTest.kt (+0 -8)

...and 8 more files

📄 Description

🎟️ Tracking

PM-24240

📔 Objective

This PR removes the email verification feature flag and the remaining logic runs as though it was always on.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/5605 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 7/28/2025 **Status:** ✅ Merged **Merged:** 7/28/2025 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `PM-24240-remove-email-verification-flag` --- ### 📝 Commits (1) - [`f8054ca`](https://github.com/bitwarden/android/commit/f8054cac09ddb98244b64192335df1297ee52c75) PM-24240: Remove email verification feature flag ### 📊 Changes **28 files changed** (+36 additions, -2177 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/auth/AuthNavigation.kt` (+0 -16) ➖ `app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/createaccount/CreateAccountNavigation.kt` (+0 -35) ➖ `app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/createaccount/CreateAccountScreen.kt` (+0 -329) ➖ `app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/createaccount/CreateAccountViewModel.kt` (+0 -595) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/landing/LandingNavigation.kt` (+0 -2) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/landing/LandingScreen.kt` (+0 -2) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/landing/LandingViewModel.kt` (+1 -15) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/welcome/WelcomeNavigation.kt` (+0 -2) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/welcome/WelcomeScreen.kt` (+0 -2) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/welcome/WelcomeViewModel.kt` (+2 -16) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/debugmenu/DebugMenuScreen.kt` (+1 -1) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/debugmenu/components/FeatureFlagListItems.kt` (+0 -2) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/platform/manager/FeatureFlagManagerTest.kt` (+3 -3) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/platform/repository/DebugMenuRepositoryTest.kt` (+3 -3) ➖ `app/src/test/kotlin/com/x8bit/bitwarden/ui/auth/feature/createaccount/CreateAccountScreenTest.kt` (+0 -319) ➖ `app/src/test/kotlin/com/x8bit/bitwarden/ui/auth/feature/createaccount/CreateAccountTestUtil.kt` (+0 -19) ➖ `app/src/test/kotlin/com/x8bit/bitwarden/ui/auth/feature/createaccount/CreateAccountViewModelTest.kt` (+0 -708) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/auth/feature/landing/LandingScreenTest.kt` (+0 -8) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/auth/feature/landing/LandingViewModelTest.kt` (+2 -22) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/auth/feature/welcome/WelcomeScreenTest.kt` (+0 -8) _...and 8 more files_ </details> ### 📄 Description ## 🎟️ Tracking [PM-24240](https://bitwarden.atlassian.net/browse/PM-24240) ## 📔 Objective This PR removes the `email verification` feature flag and the remaining logic runs as though it was always on. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-24240]: https://bitwarden.atlassian.net/browse/PM-24240?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-27 00:16:42 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5906
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?