github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-06-09 16:21:19 -05:00
Code Issues 2.2k Packages Projects Releases 127 Wiki Activity

[PR #3329] [MERGED] [PM-8137] Allow registering a passkey to a new cipher #61414

New Issue
Closed
opened 2026-05-12 00:42:16 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-12 00:42:16 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3329
Author: @SaintPatrck
Created: 6/20/2024
Status: ✅ Merged
Merged: 7/5/2024
Merged by: @SaintPatrck

Base: main ← Head: PM-8137/register-fido2-credential

📝 Commits (10+)

  • 2feea9c Register FIDO 2 credential with new cipher
  • a22d10e VaultAddEdit tests
  • 69cbd7d Implement allCredentials and findCredentials SDK callbacks
  • d38bda1 Omit PubliKeyCredentialAuthenticatorAttestationResponseExtensions from coverage reports
  • 2a1e200 Grammar fix
  • 6379dea Merge remote-tracking branch 'refs/remotes/origin/main' into PM-8137/register-fido2-credential
  • 0d25426 Set user verification supported to true while in dev
  • dcdb1eb Wrap SDK calls in runCatching and handle errors correctly
  • 98f47b0 Merge remote-tracking branch 'refs/remotes/origin/main' into PM-8137/register-fido2-credential
  • 5a49024 Document ext function

📊 Changes

34 files changed (+1713 additions, -68 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/di/Fido2ProviderModule.kt (+6 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/manager/Fido2CredentialManager.kt (+5 -5)
📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/manager/Fido2CredentialManagerImpl.kt (+69 -14)
➕ app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/model/Fido2AttestationResponse.kt (+64 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/util/CipherViewExtensions.kt (+6 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/platform/util/CallingAppInfoExtensions.kt (+30 -7)
📝 app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/sdk/VaultSdkSource.kt (+76 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/sdk/VaultSdkSourceImpl.kt (+113 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/sdk/di/VaultSdkModule.kt (+16 -0)
➕ app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/sdk/model/Fido2CredentialAuthenticationUserInterfaceImpl.kt (+36 -0)
➕ app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/sdk/model/Fido2CredentialRegistrationUserInterfaceImpl.kt (+40 -0)
➕ app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/sdk/model/Fido2CredentialStoreImpl.kt (+105 -0)
➕ app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/sdk/model/FindFido2CredentialsResult.kt (+19 -0)
➕ app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/sdk/model/RegisterFido2CredentialRequest.kt (+26 -0)
➕ app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/sdk/model/SaveCredentialResult.kt (+17 -0)
➕ app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/sdk/util/PublicKeyCredentialAuthenticatorAttestationResponseExtensions.kt (+49 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryImpl.kt (+19 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/vault/repository/di/VaultRepositoryModule.kt (+3 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditScreen.kt (+7 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModel.kt (+74 -0)

...and 14 more files

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-8137

📔 Objective

Allow users to register a new FIDO 2 credential (passkey) to a new cipher.

📸 Screenshots

imageimageimage

imageimage

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3329 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 6/20/2024 **Status:** ✅ Merged **Merged:** 7/5/2024 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `PM-8137/register-fido2-credential` --- ### 📝 Commits (10+) - [`2feea9c`](https://github.com/bitwarden/android/commit/2feea9ca746563b86fe52638752533d3387ac85f) Register FIDO 2 credential with new cipher - [`a22d10e`](https://github.com/bitwarden/android/commit/a22d10e4ea30eac5ce3cbc850ac1f4fadd12a356) VaultAddEdit tests - [`69cbd7d`](https://github.com/bitwarden/android/commit/69cbd7db65c6925bf806302078f2fd4907746db6) Implement `allCredentials` and `findCredentials` SDK callbacks - [`d38bda1`](https://github.com/bitwarden/android/commit/d38bda10235589f50b37b32aca5496650f012048) Omit PubliKeyCredentialAuthenticatorAttestationResponseExtensions from coverage reports - [`2a1e200`](https://github.com/bitwarden/android/commit/2a1e2006a6b3eda96b7b880f06b71798289eb719) Grammar fix - [`6379dea`](https://github.com/bitwarden/android/commit/6379dea85265707a2c292f863b9277fd584674ae) Merge remote-tracking branch 'refs/remotes/origin/main' into PM-8137/register-fido2-credential - [`0d25426`](https://github.com/bitwarden/android/commit/0d2542665db127fab2c239031ce821987a217480) Set user verification supported to true while in dev - [`dcdb1eb`](https://github.com/bitwarden/android/commit/dcdb1eb9ad46a95b7bdb49e938fe450b1980471e) Wrap SDK calls in runCatching and handle errors correctly - [`98f47b0`](https://github.com/bitwarden/android/commit/98f47b0eb757acd91cfdcc5ce91a3c6aafd8af7e) Merge remote-tracking branch 'refs/remotes/origin/main' into PM-8137/register-fido2-credential - [`5a49024`](https://github.com/bitwarden/android/commit/5a49024670d5c165691a539904cf5c81bf66d42e) Document ext function ### 📊 Changes **34 files changed** (+1713 additions, -68 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/di/Fido2ProviderModule.kt` (+6 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/manager/Fido2CredentialManager.kt` (+5 -5) 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/manager/Fido2CredentialManagerImpl.kt` (+69 -14) ➕ `app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/model/Fido2AttestationResponse.kt` (+64 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/util/CipherViewExtensions.kt` (+6 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/util/CallingAppInfoExtensions.kt` (+30 -7) 📝 `app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/sdk/VaultSdkSource.kt` (+76 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/sdk/VaultSdkSourceImpl.kt` (+113 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/sdk/di/VaultSdkModule.kt` (+16 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/sdk/model/Fido2CredentialAuthenticationUserInterfaceImpl.kt` (+36 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/sdk/model/Fido2CredentialRegistrationUserInterfaceImpl.kt` (+40 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/sdk/model/Fido2CredentialStoreImpl.kt` (+105 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/sdk/model/FindFido2CredentialsResult.kt` (+19 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/sdk/model/RegisterFido2CredentialRequest.kt` (+26 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/sdk/model/SaveCredentialResult.kt` (+17 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/sdk/util/PublicKeyCredentialAuthenticatorAttestationResponseExtensions.kt` (+49 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryImpl.kt` (+19 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/vault/repository/di/VaultRepositoryModule.kt` (+3 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditScreen.kt` (+7 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModel.kt` (+74 -0) _...and 14 more files_ </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-8137 ## 📔 Objective Allow users to register a new FIDO 2 credential (passkey) to a new cipher. ## 📸 Screenshots <img width="350" alt="image" src="https://github.com/bitwarden/android/assets/1883101/28787406-8e4e-4416-b470-fd21c1a64e14"><img width="350" alt="image" src="https://github.com/bitwarden/android/assets/1883101/a03899a6-e847-43b0-aff6-052072486699"><img width="350" alt="image" src="https://github.com/bitwarden/android/assets/1883101/63c9ba2c-e8ad-4407-9cf9-522fbb686852"> <img width="350" alt="image" src="https://github.com/bitwarden/android/assets/1883101/0251cc9a-4341-4b99-acae-f4e259acc8d7"><img width="350" alt="image" src="https://github.com/bitwarden/android/assets/1883101/d13f3fd0-3a09-480e-aba2-db9fa8c320ff"> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-12 00:42:16 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#61414
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?