github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-14 22:25:22 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #2063] [MERGED] [PS-1312] Migration to android12 and new splashscreen #3329

New Issue
Closed
opened 2025-11-26 23:31:18 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:31:18 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2063
Author: @aj-rosado
Created: 9/6/2022
Status: ✅ Merged
Merged: 9/16/2022
Merged by: @aj-rosado

Base: master ← Head: feature/PS-1312-update-android12-new-splashscreen

📝 Commits (8)

  • 4cbaf3e [PS-1312] Updated Android Target and Framework to Android12 and updated new SplashScreen for Android12
  • f655108 Merge branch 'master' into feature/PS-1312-update-android12-new-splashscreen
  • e447aba PS-1312 Changed PendingIntents mutability
  • 37bee88 PS-1312 Removed unused imports
  • 227e1c9 PS-1312 Added method to helper to add mutability option according to Android version
  • 16a9e6c PS-1312 Renamed helper method AddPendingIntentMutability and fixed validation
  • 1f1cc3d PS-1312 Improved PendingIntentMutability method from helper readability and naming
  • 8b10dae Merge branch 'master' into feature/PS-1312-update-android12-new-splashscreen

📊 Changes

17 files changed (+69 additions, -15 deletions)

View changed files

📝 src/Android/Accessibility/AccessibilityService.cs (+1 -1)
📝 src/Android/Android.csproj (+6 -1)
📝 src/Android/Autofill/AutofillHelpers.cs (+3 -3)
📝 src/Android/Autofill/AutofillService.cs (+1 -1)
📝 src/Android/MainActivity.cs (+3 -3)
📝 src/Android/Properties/AndroidManifest.xml (+1 -1)
➕ src/Android/Resources/drawable-night-v26/splash_screen_round.xml (+5 -0)
➕ src/Android/Resources/drawable-v26/splash_screen_round.xml (+5 -0)
➕ src/Android/Resources/drawable/logo_rounded.xml (+14 -0)
📝 src/Android/Resources/values-night/styles.xml (+1 -0)
📝 src/Android/Resources/values/styles.xml (+2 -0)
📝 src/Android/Services/ClipboardService.cs (+2 -1)
📝 src/Android/Tiles/AutofillTileService.cs (+1 -1)
📝 src/Android/Tiles/GeneratorTileService.cs (+1 -1)
📝 src/Android/Tiles/MyVaultTileService.cs (+2 -1)
📝 src/Android/Utilities/AndroidHelpers.cs (+19 -0)
📝 src/Android/WebAuthCallbackActivity.cs (+2 -1)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Make the Android migration to Android 12 including a new SplashScreen layout as Android 12 requires it.

Code changes

  • AccessibilityService.cs, AutoFillTileService.cs, AutoGeneratorTileService.cs, MyVaultTileService.cs, WebAuthCallbackActivity.cs: Added new mandatory exported tag
  • AutofillHelpers.cs, MainActivity.cs, ClipboardService.cs: Added new PendingIntent flags
  • Android.csproj, : Updated android version and added new SplashScreen files
  • AndroidManifest.xml : Updated android version
  • styles.xml : Set the values to the new Android 12 splashscreen tags

Screenshots

New Splash Screen:

Dark Theme
Screenshot 2022-09-06 at 11 29 12
Light Theme
Screenshot 2022-09-06 at 11 36 46

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2063 **Author:** [@aj-rosado](https://github.com/aj-rosado) **Created:** 9/6/2022 **Status:** ✅ Merged **Merged:** 9/16/2022 **Merged by:** [@aj-rosado](https://github.com/aj-rosado) **Base:** `master` ← **Head:** `feature/PS-1312-update-android12-new-splashscreen` --- ### 📝 Commits (8) - [`4cbaf3e`](https://github.com/bitwarden/android/commit/4cbaf3e29e12d4385ee490a54714c5afd7e5a7d8) [PS-1312] Updated Android Target and Framework to Android12 and updated new SplashScreen for Android12 - [`f655108`](https://github.com/bitwarden/android/commit/f65510839756bc835b4a2a0e6a2de8b2d7d5cf3d) Merge branch 'master' into feature/PS-1312-update-android12-new-splashscreen - [`e447aba`](https://github.com/bitwarden/android/commit/e447aba73d4950077cf47ed5c4f9809a7b8e6467) PS-1312 Changed PendingIntents mutability - [`37bee88`](https://github.com/bitwarden/android/commit/37bee88640775fdebe7e8ceab669fb25f5ebfa32) PS-1312 Removed unused imports - [`227e1c9`](https://github.com/bitwarden/android/commit/227e1c9b2434911abdff7a5fe6ae37feb816999c) PS-1312 Added method to helper to add mutability option according to Android version - [`16a9e6c`](https://github.com/bitwarden/android/commit/16a9e6c6b32b3889620124441b29a59a8e48a011) PS-1312 Renamed helper method AddPendingIntentMutability and fixed validation - [`1f1cc3d`](https://github.com/bitwarden/android/commit/1f1cc3d5fb6225de8ad62d38a5d5cadeac49f594) PS-1312 Improved PendingIntentMutability method from helper readability and naming - [`8b10dae`](https://github.com/bitwarden/android/commit/8b10dae7f19c4aa09617aea9b0906423203fa13a) Merge branch 'master' into feature/PS-1312-update-android12-new-splashscreen ### 📊 Changes **17 files changed** (+69 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Accessibility/AccessibilityService.cs` (+1 -1) 📝 `src/Android/Android.csproj` (+6 -1) 📝 `src/Android/Autofill/AutofillHelpers.cs` (+3 -3) 📝 `src/Android/Autofill/AutofillService.cs` (+1 -1) 📝 `src/Android/MainActivity.cs` (+3 -3) 📝 `src/Android/Properties/AndroidManifest.xml` (+1 -1) ➕ `src/Android/Resources/drawable-night-v26/splash_screen_round.xml` (+5 -0) ➕ `src/Android/Resources/drawable-v26/splash_screen_round.xml` (+5 -0) ➕ `src/Android/Resources/drawable/logo_rounded.xml` (+14 -0) 📝 `src/Android/Resources/values-night/styles.xml` (+1 -0) 📝 `src/Android/Resources/values/styles.xml` (+2 -0) 📝 `src/Android/Services/ClipboardService.cs` (+2 -1) 📝 `src/Android/Tiles/AutofillTileService.cs` (+1 -1) 📝 `src/Android/Tiles/GeneratorTileService.cs` (+1 -1) 📝 `src/Android/Tiles/MyVaultTileService.cs` (+2 -1) 📝 `src/Android/Utilities/AndroidHelpers.cs` (+19 -0) 📝 `src/Android/WebAuthCallbackActivity.cs` (+2 -1) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [ ] New feature development - [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective Make the Android migration to Android 12 including a new SplashScreen layout as Android 12 requires it. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **AccessibilityService.cs, AutoFillTileService.cs, AutoGeneratorTileService.cs, MyVaultTileService.cs, WebAuthCallbackActivity.cs:** Added new mandatory exported tag * **AutofillHelpers.cs, MainActivity.cs, ClipboardService.cs:** Added new PendingIntent flags * **Android.csproj, :** Updated android version and added new SplashScreen files * **AndroidManifest.xml :** Updated android version * **styles.xml :** Set the values to the new Android 12 splashscreen tags ## Screenshots New Splash Screen: Dark Theme <img width="352" alt="Screenshot 2022-09-06 at 11 29 12" src="https://user-images.githubusercontent.com/109146700/188616861-60cff2c4-2e54-4241-83f5-b97698da1a3f.png"> Light Theme <img width="354" alt="Screenshot 2022-09-06 at 11 36 46" src="https://user-images.githubusercontent.com/109146700/188616866-1ee43cf3-5bcf-41a8-bdb7-0601d4f9681f.png"> ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:31:18 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3329
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?