github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-18 14:19:36 -05:00
Code Issues 1.3k Packages Projects Releases 125 Wiki Activity

[PR #3149] [MERGED] [PM-7379] Fix incorrect passkey used because creating the PendingIntent wrongly #61320

New Issue
Closed
opened 2026-05-12 00:36:33 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-12 00:36:33 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3149
Author: @fedemkr
Created: 4/11/2024
Status: ✅ Merged
Merged: 4/11/2024
Merged by: @vvolkgang

Base: feature/maui-migration-passkeys ← Head: vault/pm-7379/fix-incorrect-passkey-selected-when-more-than-one-login-exists

📝 Commits (1)

  • e7cd3bf PM-7379 Fix creating the PendingIntent for a passkey credential on Android so it has different request codes amongst each other so the extras are not overriden by the last credential entry created.

📊 Changes

1 file changed (+6 additions, -3 deletions)

View changed files

📝 src/App/Platforms/Android/Autofill/CredentialHelpers.cs (+6 -3)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Fix incorrect passkey used when more than one passkey available for the same RP.
When "PasskeyA" and "PasskeyB" were being displayed for the same RP and the user selected "PasskeyA" it was being logged with "PasskeyB".

Code changes

  • CredentialHelpers: Change the PendingIntent.GetActivity to have a unique request code for each credential entry so the extras are not overridden by the last one.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3149 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 4/11/2024 **Status:** ✅ Merged **Merged:** 4/11/2024 **Merged by:** [@vvolkgang](https://github.com/vvolkgang) **Base:** `feature/maui-migration-passkeys` ← **Head:** `vault/pm-7379/fix-incorrect-passkey-selected-when-more-than-one-login-exists` --- ### 📝 Commits (1) - [`e7cd3bf`](https://github.com/bitwarden/android/commit/e7cd3bf5ed167490a13cb9c986c15a5872348cb3) PM-7379 Fix creating the PendingIntent for a passkey credential on Android so it has different request codes amongst each other so the extras are not overriden by the last credential entry created. ### 📊 Changes **1 file changed** (+6 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Platforms/Android/Autofill/CredentialHelpers.cs` (+6 -3) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Fix incorrect passkey used when more than one passkey available for the same RP. When "PasskeyA" and "PasskeyB" were being displayed for the same RP and the user selected "PasskeyA" it was being logged with "PasskeyB". ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **CredentialHelpers:** Change the `PendingIntent.GetActivity` to have a unique request code for each credential entry so the extras are not overridden by the last one. ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-12 00:36:33 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#61320
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?