github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-17 12:36:15 -05:00
Code Issues 1.3k Packages Projects Releases 125 Wiki Activity

[PR #1813] [MERGED] BEEEP: Colorize hidden custom field when value visible #3149

New Issue
Closed
opened 2025-11-26 23:28:55 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:28:55 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1813
Author: @djsmith85
Created: 2/25/2022
Status: ✅ Merged
Merged: 2/25/2022
Merged by: @djsmith85

Base: master ← Head: colorize-hidden-custom-field

📝 Commits (1)

  • c11927a BEEEP: Colorize hidden custom field when value visible

📊 Changes

2 files changed (+5 additions, -3 deletions)

View changed files

📝 src/App/Pages/Vault/ViewPage.xaml (+2 -2)
📝 src/App/Pages/Vault/ViewPageViewModel.cs (+3 -1)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

The standard password field displays number and special characters in a different color for better readability. A hidden custom-field currently does not colorize it's value when shown.

Asana task: https://app.asana.com/0/1200804338582616/1201884248598927/f

Code changes

  • src/App/Pages/Vault/ViewPageViewModel.cs: Add new public property ColoredHiddenValue which formats the hidden custom field value
  • src/App/Pages/Vault/ViewPage.xaml: Adjust hidden fieldvalue binding to new property and add text-html to StyleClass

Screenshots

BEFORE:
image

AFTER:
image

Testing requirements

When the value of a hidden custom field is shown, it should be colorized as the standard password field

Before you submit

  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1813 **Author:** [@djsmith85](https://github.com/djsmith85) **Created:** 2/25/2022 **Status:** ✅ Merged **Merged:** 2/25/2022 **Merged by:** [@djsmith85](https://github.com/djsmith85) **Base:** `master` ← **Head:** `colorize-hidden-custom-field` --- ### 📝 Commits (1) - [`c11927a`](https://github.com/bitwarden/android/commit/c11927a35a94ad73afafa377ee3ad39ea23ea971) BEEEP: Colorize hidden custom field when value visible ### 📊 Changes **2 files changed** (+5 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Vault/ViewPage.xaml` (+2 -2) 📝 `src/App/Pages/Vault/ViewPageViewModel.cs` (+3 -1) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [X] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective The standard password field displays number and special characters in a different color for better readability. A hidden custom-field currently does not colorize it's value when shown. Asana task: https://app.asana.com/0/1200804338582616/1201884248598927/f ## Code changes * **src/App/Pages/Vault/ViewPageViewModel.cs:** Add new public property ColoredHiddenValue which formats the hidden custom field value * **src/App/Pages/Vault/ViewPage.xaml:** Adjust hidden fieldvalue binding to new property and add text-html to StyleClass ## Screenshots **BEFORE:** ![image](https://user-images.githubusercontent.com/2670567/155734787-46730156-ae72-432a-9f4c-b386f8d3747c.png) **AFTER:** ![image](https://user-images.githubusercontent.com/2670567/155734738-2fe1f7ac-394f-4093-a559-a78fc36f386b.png) ## Testing requirements When the value of a hidden custom field is shown, it should be colorized as the standard password field ## Before you submit - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:28:55 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3149
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?