github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-17 03:59:18 -05:00
Code Issues 1.3k Packages Projects Releases 125 Wiki Activity

[PR #3058] [MERGED] [PM-6496] Improved iOS extensions cipher cell UI #61266

New Issue
Closed
opened 2026-05-12 00:32:40 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-12 00:32:40 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3058
Author: @fedemkr
Created: 3/6/2024
Status: ✅ Merged
Merged: 3/8/2024
Merged by: @fedemkr

Base: feature/maui-migration-passkeys ← Head: vault/pm-6496/save-passkey-ui-tweaks

📝 Commits (2)

  • 6e4123d PM-6496 Improved iOS extensions cipher list to have an updated UI for each cell
  • b08e43f PM-6496 Improved UI on iOS extensions list cells

📊 Changes

8 files changed (+209 additions, -42 deletions)

View changed files

📝 src/iOS.Autofill/ListItems/HeaderItemView.cs (+12 -11)
📝 src/iOS.Autofill/LoginListViewController.cs (+5 -4)
📝 src/iOS.Autofill/LoginSearchViewController.cs (+5 -1)
📝 src/iOS.Core/Controllers/ExtendedUITableViewCell.cs (+35 -7)
📝 src/iOS.Core/Models/CipherViewModel.cs (+4 -0)
➕ src/iOS.Core/Views/CipherLoginTableViewCell.cs (+110 -0)
📝 src/iOS.Core/Views/ExtensionTableSource.cs (+33 -16)
📝 src/iOS.Extension/LoginListViewController.cs (+5 -3)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Improved iOS extensions cipher cell UI to support passkeys

Code changes

  • CipherLoginTableViewCell: New Cell with the updated UI for cipher login / passkeys
  • ExtensionTableSource: Updated it to use new cell and also to calculate the header and fill the cell correctly
  • Other: Updated code to use new cells / table source

Screenshots

iOS extensions cipher list

iOS extensions cipher list

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3058 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 3/6/2024 **Status:** ✅ Merged **Merged:** 3/8/2024 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `feature/maui-migration-passkeys` ← **Head:** `vault/pm-6496/save-passkey-ui-tweaks` --- ### 📝 Commits (2) - [`6e4123d`](https://github.com/bitwarden/android/commit/6e4123db7ce7decf6c6ab1df93da7bb38179c042) PM-6496 Improved iOS extensions cipher list to have an updated UI for each cell - [`b08e43f`](https://github.com/bitwarden/android/commit/b08e43f5d2fcc229adbfde9b9b3f7fb02d72ae40) PM-6496 Improved UI on iOS extensions list cells ### 📊 Changes **8 files changed** (+209 additions, -42 deletions) <details> <summary>View changed files</summary> 📝 `src/iOS.Autofill/ListItems/HeaderItemView.cs` (+12 -11) 📝 `src/iOS.Autofill/LoginListViewController.cs` (+5 -4) 📝 `src/iOS.Autofill/LoginSearchViewController.cs` (+5 -1) 📝 `src/iOS.Core/Controllers/ExtendedUITableViewCell.cs` (+35 -7) 📝 `src/iOS.Core/Models/CipherViewModel.cs` (+4 -0) ➕ `src/iOS.Core/Views/CipherLoginTableViewCell.cs` (+110 -0) 📝 `src/iOS.Core/Views/ExtensionTableSource.cs` (+33 -16) 📝 `src/iOS.Extension/LoginListViewController.cs` (+5 -3) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Improved iOS extensions cipher cell UI to support passkeys ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **CipherLoginTableViewCell:** New Cell with the updated UI for cipher login / passkeys * **ExtensionTableSource:** Updated it to use new cell and also to calculate the header and fill the cell correctly * **Other:** Updated code to use new cells / table source ## Screenshots <!--Required for any UI changes. Delete if not applicable--> ### iOS extensions cipher list <img width="314" alt="iOS extensions cipher list" src="https://github.com/bitwarden/mobile/assets/15682323/250a626d-ea04-4264-9c7c-1f239daa3c7f"> ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-12 00:32:40 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#61266
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?